<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div><br><br>Sent from my iPad</div><div><br>On Mar 18, 2013, at 2:02 PM, Justin Holewinski <<a href="mailto:justin.holewinski@gmail.com">justin.holewinski@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr">Compile-time impact is negligible for a release build on the unit tests. There is about an 8% impact with assertions enabled.</div></div></blockquote><div><br></div>Unit tests are much too small for measuring compile time. 8% for assertion build is massive. Why are there such large discrepancy?<div><br></div><div>Evan</div><div><br><blockquote type="cite"><div><div dir="ltr"><div><br></div><div style="">I'm not sure how CSE factors in here. This propagation happens during legalization. I agree that it should be addressed, but I see it as a separate issue. Unless I'm missing some instance of CSE being performed during legalization?</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Mar 18, 2013 at 4:04 PM, Jakob Stoklund Olesen <span dir="ltr"><<a href="mailto:stoklund@2pi.dk" target="_blank">stoklund@2pi.dk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><div class="im"><div>On Mar 15, 2013, at 10:51 AM, Justin Holewinski <<a href="mailto:justin.holewinski@gmail.com" target="_blank">justin.holewinski@gmail.com</a>> wrote:</div>
<br><blockquote type="cite"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div dir="ltr">Thanks Jakob!<div><br></div><div>Modified patch attached. Anyone adverse to this change?</div>
</div></div></blockquote><div><br></div></div><div><div>+</div><div>+ // Propagate ordering</div><div>+ unsigned Order = DAG.GetOrdering(Op.getNode());</div><div>+ DAG.AssignOrdering(Lo.getNode(), Order);</div><div>+ DAG.AssignOrdering(Hi.getNode(), Order);</div>
<div> </div><div>Did you consider what happens when CSE kicks in? The new nodes may not be new, they could have been CSE'ed with an existing expression.</div><div><br></div><div>When that happens, the ordering should be the earlier of the two.</div>
<div><br></div><div>I think it would make sense to teach the SDNodeOrdering class about this.</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>/jakob</div><div><br></div></font></span></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><br><div>Thanks,</div><div><br></div><div>Justin Holewinski</div>
</div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>llvm-commits mailing list</span><br><span><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a></span><br><span><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></span><br></div></blockquote></div></body></html>