<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Mar 18, 2013, at 1:32 AM, Stepan Dyatkovskiy <<a href="mailto:stpworld@narod.ru">stpworld@narod.ru</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">Hello Chad.<br>Sorry about that, a little bit confused by ogre3d style. Variable name was fixed. I also replaced the comment.<br>Unittest is applied.<br></div></blockquote><div><br></div><div>Great, thanks.</div><div><br></div><div><div>+ // If we've seen a branch mnemonic, the next operand must be a label then.</div><div>+ // Even if it named as register. So "br r1" would mean:</div><div>+ // branch to "r1" label.</div><div><br></div><div>Perhaps this comment:</div><div><div><br></div><div>// If we've seen a branch mnemonic, the next operand must be a label.</div><div>// This is true even if the label is a register name. So "br r1" means</div><div>// branch to label "r1."</div></div></div><div><br></div><div>If you have commit access, please go ahead and commit the patch. Otherwise, let me know and I'll commit on you behalf.</div><div><br></div><div> Chad</div><br><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">-Stepan.<br><br>Chad Rosier wrote:<br><blockquote type="cite">Hi Stepan,<br>Here are a few nits:<br><br>When writing comments, write them as English prose, which means they<br>should use proper capitalization, punctuation, etc.<br><br>+ // Want label whatever happened...<br>+ bool wantLabelOnly = Mnemonic == "b" || Mnemonic == "bl";<br><br>Maybe the comment could be something like, "If we've seen a branch<br>mnemonic, the next operand must be a label."<br><br>You could also rename wantLabelOnly to ExpectLabel or just put the<br>conditional in the if statement; the comment should make clear the<br>condition of the if statement.<br><br>Most importantly, please add a test case before resubmitting to the list.<br><br> Chad<br></blockquote><br><span><pr13145.patch></span></div></blockquote></div><br></body></html>