<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Mar 18, 2013, at 11:33 AM, Ulrich Weigand <<a href="mailto:Ulrich.Weigand@de.ibm.com">Ulrich.Weigand@de.ibm.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">Jakob Stoklund Olesen <<a href="mailto:stoklund@2pi.dk">stoklund@2pi.dk</a>> wrote on 05.03.2013 19:46:10:<br><br><blockquote type="cite">This generally looks good, but please add some documentation of the<br></blockquote>feature.<br><blockquote type="cite"><br>Also, please break the target changes into separate patches. The X86<br>issue seems almost unrelated.<br></blockquote><br>Hi Jakob,<br><br>thanks for the review! And sorry for the late reply; I've been out<br>sick for the last two weeks ...<br><br>I've attached an updated version of the patch that:<br>- breaks out just the TableGen core changes<br>- is updated for your latest changes (this made the patch<br> actually shorter, thanks!)<br>- adds documentation ... I hope I found the correct place<br><br>Would this be OK?<br></div></blockquote><div><br></div><div>Perfect, thanks.</div><div><br></div><div>/jakob</div><div><br></div></div></body></html>