<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Stepan,<div>Here are a few nits:</div><div><br></div><div>When writing comments, write them as English prose, which means they should use proper capitalization, punctuation, etc.</div><div><br></div><div><div>+ // Want label whatever happened...</div><div>+ bool wantLabelOnly = Mnemonic == "b" || Mnemonic == "bl";</div></div><div><br></div><div>Maybe the comment could be something like, "If we've seen a branch mnemonic, the next operand must be a label."</div><div><br></div><div>You could also rename wantLabelOnly to ExpectLabel or just put the conditional in the if statement; the comment should make clear the condition of the if statement.</div><div><br></div><div>Most importantly, please add a test case before resubmitting to the list.</div><div><br></div><div> Chad</div><div><br></div><div><div><div>On Mar 15, 2013, at 1:29 AM, Stepan Dyatkovskiy <<a href="mailto:stpworld@narod.ru">stpworld@narod.ru</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">Hi all!<br>Please review the patch in attachment as fix for PR13145.<br>Patch adds special condition for identifier parsing, for case when mnemonic is "b" or "bl": even operands like "r1" would be treated as labels.<br><br>-Stepan.<br><span><pr13145.patch></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></body></html>