<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Justin,<div><br></div><div>The x87 stack is always a bit strange. It's probably easier to compare the outputs of -print-machineinstrs.</div><div><br></div><div>/jakob</div><div><br><div><div>On Mar 15, 2013, at 7:54 AM, Justin Holewinski <<a href="mailto:justin.holewinski@gmail.com">justin.holewinski@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><div dir="ltr"><div>The attached patch modifies DAGTypeLegalizer and SelectionDAGISel to propagate DAG node ordering. We currently (for better or for worse) use source scheduling, and we're being hit by issues in the scheduler due to the ordering being lost.</div><div><br></div><div><br></div><div>One issue with this patch is that is causes one X86 test to fail: win_ftol2</div><div><br></div><div>The only meaningful difference I can spot (other than an extra spill) is that the 'fxch' instruction is eliminated. Can anyone more familiar with the X86 back-end comment on why DAG node ordering would affect this test? I've narrowed the issue down to being caused by this patch's change to DAGTypeLegalizer::SetExpandedInteger. (e.g. if this method propagates DAG node ordering in the newly created nodes, this test starts to fail).</div><div><br></div><div><br></div><div>Current Output:</div><div><br></div><div><div><font face="courier new, monospace">_double_ui64_2: # @double_ui64_2</font></div><div><font face="courier new, monospace"># BB#0:</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>pushl<span class="" style="white-space: pre;"> </span>%ebp</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>movl<span class="" style="white-space: pre;"> </span>%esp, %ebp</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>pushl<span class="" style="white-space: pre;"> </span>%esi</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>andl<span class="" style="white-space: pre;"> </span>$-8, %esp</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>subl<span class="" style="white-space: pre;"> </span>$32, %esp</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>fldl<span class="" style="white-space: pre;"> </span>24(%ebp)</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>fldl<span class="" style="white-space: pre;"> </span>16(%ebp)</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>fldl<span class="" style="white-space: pre;"> </span>8(%ebp)</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>fdiv<span class="" style="white-space: pre;"> </span>%st(0), %st(1)</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>fsubp<span class="" style="white-space: pre;"> </span>%st(2)</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>fxch</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>calll<span class="" style="white-space: pre;"> </span>__ftol2</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>movl<span class="" style="white-space: pre;"> </span>%eax, 4(%esp) # 4-byte Spill</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>movl<span class="" style="white-space: pre;"> </span>%edx, (%esp) # 4-byte Spill</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>calll<span class="" style="white-space: pre;"> </span>__ftol2</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>movl<span class="" style="white-space: pre;"> </span>4(%esp), %ecx # 4-byte Reload</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>subl<span class="" style="white-space: pre;"> </span>%ecx, %eax</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>movl<span class="" style="white-space: pre;"> </span>(%esp), %esi # 4-byte Reload</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>sbbl<span class="" style="white-space: pre;"> </span>%esi, %edx</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>leal<span class="" style="white-space: pre;"> </span>-4(%ebp), %esp</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>popl<span class="" style="white-space: pre;"> </span>%esi</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>popl<span class="" style="white-space: pre;"> </span>%ebp</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>ret</font></div><div><br></div><div><br></div><div>Output With Patch:</div><div><br></div><div><div><font face="courier new, monospace">_double_ui64_2: # @double_ui64_2</font></div><div><font face="courier new, monospace"># BB#0:</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>pushl<span class="" style="white-space: pre;"> </span>%ebp</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>movl<span class="" style="white-space: pre;"> </span>%esp, %ebp</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>andl<span class="" style="white-space: pre;"> </span>$-8, %esp</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>subl<span class="" style="white-space: pre;"> </span>$32, %esp</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>fldl<span class="" style="white-space: pre;"> </span>24(%ebp)</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>fldl<span class="" style="white-space: pre;"> </span>16(%ebp)</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>fldl<span class="" style="white-space: pre;"> </span>8(%ebp)</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>fdiv<span class="" style="white-space: pre;"> </span>%st(0), %st(1)</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>fsubp<span class="" style="white-space: pre;"> </span>%st(2)</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>calll<span class="" style="white-space: pre;"> </span>__ftol2</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>movl<span class="" style="white-space: pre;"> </span>%eax, 12(%esp) # 4-byte Spill</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>movl<span class="" style="white-space: pre;"> </span>%edx, 8(%esp) # 4-byte Spill</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>calll<span class="" style="white-space: pre;"> </span>__ftol2</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>movl<span class="" style="white-space: pre;"> </span>12(%esp), %ecx # 4-byte Reload</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>subl<span class="" style="white-space: pre;"> </span>%eax, %ecx</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>movl<span class="" style="white-space: pre;"> </span>8(%esp), %eax # 4-byte Reload</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>sbbl<span class="" style="white-space: pre;"> </span>%edx, %eax</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>movl<span class="" style="white-space: pre;"> </span>%eax, 4(%esp) # 4-byte Spill</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>movl<span class="" style="white-space: pre;"> </span>%ecx, %eax</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>movl<span class="" style="white-space: pre;"> </span>4(%esp), %edx # 4-byte Reload</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>movl<span class="" style="white-space: pre;"> </span>%ebp, %esp</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>popl<span class="" style="white-space: pre;"> </span>%ebp</font></div><div><font face="courier new, monospace"><span class="" style="white-space: pre;"> </span>ret</font></div></div></div><br clear="all"><div><br></div>--<span class="Apple-converted-space"> </span><br><br><div>Thanks,</div><div><br></div><div>Justin Holewinski</div></div><span><0001-Propagate-DAG-node-ordering-during-type-legalization.patch></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></body></html>