<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">on 2013/3/15 16:28, Chandler Carruth
wrote:<br>
<br>
Hi Chandler,<br>
<br>
thanks for feedback.<br>
<br>
</div>
<blockquote
cite="mid:CAGCO0Kjudk_KnEQvWEMDV5Au1w9gEK0gY8Or0QFBRcn=L_7G_Q@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div dir="ltr">I've not looked in detail at any of the patches, or
any of the review threads, but unless you receive a very
explicit LGTM from one of the committers to a particular area, I
think you should hold off submitting.</div>
</blockquote>
<br>
sure, I am keep this in mind and will follow it.<br>
<blockquote
cite="mid:CAGCO0Kjudk_KnEQvWEMDV5Au1w9gEK0gY8Or0QFBRcn=L_7G_Q@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<br>
</div>
<div style="">For a really large new body of code like this, I
think having at least some pre-commit review is important. I
think it is especially important for new contributors to the
project to help bring them up to speed. Unfortunately, this is
a *huge* amount of code, and so it is likely to take quite
some time to really get reviews on all of it. Please be
patient in that regard.</div>
</div>
</blockquote>
<blockquote
cite="mid:CAGCO0Kjudk_KnEQvWEMDV5Au1w9gEK0gY8Or0QFBRcn=L_7G_Q@mail.gmail.com"
type="cite">
<div dir="ltr">
<div style=""><br>
</div>
<div style="">The best thing you can do to help accelerate the
process is to dive in and contribute to the shared parts of
the open source project to help the current maintainers, and
maybe even free up some of their time to review your patches.
Because LLVM is open source, it is really important to the
project for folks working on a specific target, backend, or
application to also help share the ongoing maintenance and
improvement costs of the core shared infrastructure in the
compiler.</div>
</div>
</blockquote>
<br>
yes, some of these points are also my thoughts. but it will be
hard to follow before tilegx merged to llvm community, because it
will take much time to keep pace, and I need re-test, re-patch etc.<br>
<br>
I agree that everyone should contribute to keep the community
active and vigorious. But I think there are difference between
contributors.<br>
<br>
some are focused and with expertise on middle end, while others
may on front or back end. so the normal way for a new contributor
is, find a familiar point to start, then go deeper and wider and
expand one's contribution during this process.<br>
<br>
For Tilera corporation and me, we would like the keep tilegx
backend actively maintained and improved, and wish it could be a
good target to improve and test VLIW, many core features etc.<br>
<br>
---<br>
Regards,<br>
Jiong<br>
Tilera Corporation. <br>
<br>
<blockquote
cite="mid:CAGCO0Kjudk_KnEQvWEMDV5Au1w9gEK0gY8Or0QFBRcn=L_7G_Q@mail.gmail.com"
type="cite">
<div dir="ltr">
<div style=""><br>
</div>
<div style="">-Chandler</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Fri, Mar 15, 2013 at 12:15 AM, Jiong
Wang <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:jiwang@tilera.com" target="_blank">jiwang@tilera.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hi All,<br>
<br>
As you have seen, I had sent all tilegx patches to get code
review, and<br>
thanks for all the feedbacks on coding style and simplifing
the code.<br>
<br>
So, is it OK to commit TILE-Gx backend to community master
and let it<br>
default disabled?<br>
<br>
Tilera's recent plan about TILE-Gx backend is:<br>
<br>
1. merge the current tilegx support to community master, so
that we<br>
could go on the next stage development with more community
interaction,<br>
including AsmParser for VLIW bundle, hardware float
optimization, SIMD<br>
support etc.<br>
2. we will contribute a tilegx buildbot once the code
merged, so that<br>
it's good for both the community and company to monitor
tilegx status.<br>
Actually, I have verified the buildbot environment on tilegx
server, all<br>
OK, just wait for the merge, then it could svn co code from
community<br>
and build :)<br>
<br>
if there is any important step I have missed or am wrong
that block<br>
tilegx backend committed, please feel free to point out so
that I could<br>
correct it.<br>
<br>
thank you, looking forward to your reply.<br>
<br>
---<br>
Regards,<br>
Jiong<br>
Tilera Corporation.<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>