<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Mar 14, 2013 at 11:21 PM, Alexey Samsonov <span dir="ltr"><<a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote"><div class="im">On Fri, Mar 15, 2013 at 4:20 AM, Eric Christopher <span dir="ltr"><<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: echristo<br>
Date: Thu Mar 14 19:20:17 2013<br>
New Revision: 177132<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=177132&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=177132&view=rev</a><br>
Log:<br>
Fix a virtual destructor warning.<br>
<br>
Patch by Manuel Klimek!<br></blockquote><div><br></div></div><div>Thanks! Should we make this warning fire in CMake build + LLVM_ENABLE_WERROR?</div><div><div class="h5"><div> </div></div></div></div></div></div></blockquote>
<div><br></div><div style>Mmm. Probably.</div><div style><br></div><div style>-eric</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra">
<div class="gmail_quote"><div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc<br>
compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.h<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc?rev=177132&r1=177131&r2=177132&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc?rev=177132&r1=177131&r2=177132&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc Thu Mar 14 19:20:17 2013<br>
@@ -22,6 +22,8 @@ ThreadContextBase::ThreadContextBase(u32<br>
name[0] = '\0';<br>
}<br>
<br>
+ThreadContextBase::~ThreadContextBase() {}<br>
+<br>
void ThreadContextBase::SetName(const char *new_name) {<br>
name[0] = '\0';<br>
if (new_name) {<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.h?rev=177132&r1=177131&r2=177132&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.h?rev=177132&r1=177131&r2=177132&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.h (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.h Thu Mar 14 19:20:17 2013<br>
@@ -34,6 +34,7 @@ enum ThreadStatus {<br>
class ThreadContextBase {<br>
public:<br>
explicit ThreadContextBase(u32 tid);<br>
+ virtual ~ThreadContextBase();<br>
<br>
const u32 tid; // Thread ID. Main thread should have tid = 0.<br>
u64 unique_id; // Unique thread ID.<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</font></span></div></div>
</blockquote></div><br></div></div>