<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Hi,</div><br><div><div>On Mar 12, 2013, at 12:28 PM, Michael J. Spencer <<a href="mailto:bigcheesegs@gmail.com">bigcheesegs@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; float: none; display: inline !important;"> error_code ret = getOpenFile(FD, Filename, result, FileSize, FileSize,</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; float: none; display: inline !important;"> 0, RequiresNullTerminator);</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">- close(FD);</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; float: none; display: inline !important;"> return ret;</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">}</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"></blockquote></div><br><div>I believe your commit caused clang to leak file descriptors, I get a couple of test failures from "Too many open files" error (I'm on a mac):</div><div><br></div><div><div>FAIL: Clang :: Modules/compiler_builtins.m (1 of 1)</div><div>******************** TEST 'Clang :: Modules/compiler_builtins.m' FAILED ********************</div><div>Script:</div><div>--</div><div>rm -rf /Volumes/HD/Users/argiris/proj/llvm/clang-build/tools/clang/test/Modules/Output/compiler_builtins.m.tmp</div><div>/Volumes/HD/Users/argiris/proj/llvm/clang-build/Debug+Asserts/bin/clang -fsyntax-only -fmodules -fmodules-cache-path=/Volumes/HD/Users/argiris/proj/llvm/clang-build/tools/clang/test/Modules/Output/compiler_builtins.m.tmp -D__need_wint_t /Volumes/HD/Users/argiris/proj/llvm/src/tools/clang/test/Modules/compiler_builtins.m -Xclang -verify</div><div>/Volumes/HD/Users/argiris/proj/llvm/clang-build/Debug+Asserts/bin/clang -fsyntax-only -std=c99 -fmodules -fmodules-cache-path=/Volumes/HD/Users/argiris/proj/llvm/clang-build/tools/clang/test/Modules/Output/compiler_builtins.m.tmp -D__need_wint_t /Volumes/HD/Users/argiris/proj/llvm/src/tools/clang/test/Modules/compiler_builtins.m -Xclang -verify</div><div>--</div><div>Exit Code: 1</div><div>Command Output (stderr):</div><div>--</div><div>error: no expected directives found: consider use of 'expected-no-diagnostics'</div><div>error: 'error' diagnostics seen but not expected: </div><div> Line 82: cannot open file '/usr/include/mach/host_special_ports.h': Too many open files</div><div>2 errors generated.</div></div><div><br></div><div><br></div><div>There are no test failures if I revert your commit.</div><div>Could you revert and investigate please ?</div><div><br></div><div>-Argyrios</div></body></html>