<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">LGTM. <div><br><div><div><div>On Mar 12, 2013, at 9:15 AM, "Relph, Richard" <<a href="mailto:Richard.Relph@amd.com">Richard.Relph@amd.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">Per discussion on LLVMDev, implement Nadav's suggested fix to DAGCombiner::visitSIGN_EXTEND() to prevent 'optimization' of SIGN_EXTEND to SELECT if we are sign-extending a vector…<br><br>Index: lib/CodeGen/SelectionDAG/DAGCombiner.cpp<br>===================================================================<br>--- lib/CodeGen/SelectionDAG/DAGCombiner.cpp<span class="Apple-tab-span" style="white-space: pre;"> </span>(revision 176837)<br>+++ lib/CodeGen/SelectionDAG/DAGCombiner.cpp<span class="Apple-tab-span" style="white-space: pre;"> </span>(working copy)<br>@@ -4496,8 +4496,8 @@<br> NegOne, DAG.getConstant(0, VT),<br> cast<CondCodeSDNode>(N0.getOperand(2))->get(), true);<br> if (SCC.getNode()) return SCC;<br>- if (!LegalOperations ||<br>- TLI.isOperationLegal(ISD::SETCC, TLI.getSetCCResultType(VT)))<br>+ if (!VT.isVector() && (!LegalOperations ||<br>+ TLI.isOperationLegal(ISD::SETCC, TLI.getSetCCResultType(VT))))<br> return DAG.getNode(ISD::SELECT, N->getDebugLoc(), VT,<br> DAG.getSetCC(N->getDebugLoc(),<br> TLI.getSetCCResultType(VT),<br><br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></div></body></html>