<p dir="ltr"><br>
On Mar 9, 2013 3:00 PM, "Lang Hames" <<a href="mailto:lhames@gmail.com">lhames@gmail.com</a>> wrote:<br>
><br>
> Author: lhames<br>
> Date: Sat Mar  9 16:56:09 2013<br>
> New Revision: 176777<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=176777&view=rev">http://llvm.org/viewvc/llvm-project?rev=176777&view=rev</a><br>
> Log:<br>
> Don't glue users to extract_subreg when selecting the llvm.arm.ldrexd<br>
> intrinsic - it can cause impossible-to-schedule subgraphs to be<br>
> introduced.<br>
><br>
> PR15053.<br>
><br>
><br>
> Added:<br>
>     llvm/trunk/test/CodeGen/ARM/2013-03-09-PR15053.ll</p>
<p dir="ltr">Not sure if this is universally true but in many parts of llvm & clang we've generally moved away from putting dates in test case names like this.</p>
<p dir="ltr">(And the other caveat of: if possible, it's nice to add a test case to an existing test file/run than to add another - reducing the number of processes created keeps test cycle time low)</p>
<p dir="ltr">> Modified:<br>
>     llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp<br>
><br>
> Modified: llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp?rev=176777&r1=176776&r2=176777&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp?rev=176777&r1=176776&r2=176777&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp (original)<br>
> +++ llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp Sat Mar  9 16:56:09 2013<br>
> @@ -3155,7 +3155,7 @@ SDNode *ARMDAGToDAGISel::Select(SDNode *<br>
>        cast<MachineSDNode>(Ld)->setMemRefs(MemOp, MemOp + 1);<br>
><br>
>        // Remap uses.<br>
> -      SDValue Glue = isThumb ? SDValue(Ld, 2) : SDValue(Ld, 1);<br>
> +      SDValue OutChain = isThumb ? SDValue(Ld, 2) : SDValue(Ld, 1);<br>
>        if (!SDValue(N, 0).use_empty()) {<br>
>          SDValue Result;<br>
>          if (isThumb)<br>
> @@ -3163,9 +3163,8 @@ SDNode *ARMDAGToDAGISel::Select(SDNode *<br>
>          else {<br>
>            SDValue SubRegIdx = CurDAG->getTargetConstant(ARM::gsub_0, MVT::i32);<br>
>            SDNode *ResNode = CurDAG->getMachineNode(TargetOpcode::EXTRACT_SUBREG,<br>
> -              dl, MVT::i32, MVT::Glue, SDValue(Ld, 0), SubRegIdx, Glue);<br>
> +              dl, MVT::i32, SDValue(Ld, 0), SubRegIdx);<br>
>            Result = SDValue(ResNode,0);<br>
> -          Glue = Result.getValue(1);<br>
>          }<br>
>          ReplaceUses(SDValue(N, 0), Result);<br>
>        }<br>
> @@ -3176,13 +3175,12 @@ SDNode *ARMDAGToDAGISel::Select(SDNode *<br>
>          else {<br>
>            SDValue SubRegIdx = CurDAG->getTargetConstant(ARM::gsub_1, MVT::i32);<br>
>            SDNode *ResNode = CurDAG->getMachineNode(TargetOpcode::EXTRACT_SUBREG,<br>
> -              dl, MVT::i32, MVT::Glue, SDValue(Ld, 0), SubRegIdx, Glue);<br>
> +              dl, MVT::i32, SDValue(Ld, 0), SubRegIdx);<br>
>            Result = SDValue(ResNode,0);<br>
> -          Glue = Result.getValue(1);<br>
>          }<br>
>          ReplaceUses(SDValue(N, 1), Result);<br>
>        }<br>
> -      ReplaceUses(SDValue(N, 2), Glue);<br>
> +      ReplaceUses(SDValue(N, 2), OutChain);<br>
>        return NULL;<br>
>      }<br>
><br>
><br>
> Added: llvm/trunk/test/CodeGen/ARM/2013-03-09-PR15053.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/2013-03-09-PR15053.ll?rev=176777&view=auto">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/2013-03-09-PR15053.ll?rev=176777&view=auto</a><br>

> ==============================================================================<br>
> --- llvm/trunk/test/CodeGen/ARM/2013-03-09-PR15053.ll (added)<br>
> +++ llvm/trunk/test/CodeGen/ARM/2013-03-09-PR15053.ll Sat Mar  9 16:56:09 2013<br>
> @@ -0,0 +1,13 @@<br>
> +; RUN: llc -mtriple=armv7 < %s<br>
> +; PR15053<br>
> +<br>
> +declare i32 @llvm.arm.strexd(i32, i32, i8*) nounwind<br>
> +declare { i32, i32 } @llvm.arm.ldrexd(i8*) nounwind readonly<br>
> +<br>
> +define void @foo() {<br>
> +entry:<br>
> +  %0 = tail call { i32, i32 } @llvm.arm.ldrexd(i8* undef) nounwind<br>
> +  %1 = extractvalue { i32, i32 } %0, 0<br>
> +  %2 = tail call i32 @llvm.arm.strexd(i32 %1, i32 undef, i8* undef) nounwind<br>
> +  ret void<br>
> +}<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></p>