<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Mar 6, 2013, at 6:07 PM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Mar 6, 2013 at 5:42 PM, Manman Ren <span dir="ltr"><<a href="mailto:mren@apple.com" target="_blank">mren@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: mren<br>
Date: Wed Mar 6 19:42:00 2013<br>
New Revision: 176605<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=176605&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=176605&view=rev</a><br>
Log:<br>
Debug Info: store the files and directories for each compile unit.<br>
<br>
We now emit a line table for each compile unit. To reduce the prologue size<br>
of each line table, the files and directories used by each compile unit are<br>
stored in std::map<unsigned, std::vector< > > instead of std::vector< >.<br>
<br>
The prologue for a lto'ed image can be as big as 93K. Duplicating 93K for each<br>
compile unit causes a huge increase of debug info. With this patch, each<br>
prologue will only emit the files required by the compile unit.<br></blockquote><div><br></div><div style="">Looks good. Any reason not to use SmallVector instead?</div></div></div></div></blockquote><div><br></div>I replaced std::vector with std::map<unsigned, std::vector> to keep the changes minimal.</div><div>We should be able to replace std::map<unsigned, std::vector> with std::map<unsigned, SmallVector>.</div><div><br></div><div>-Manman<br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div style=""><br></div><div style="">-eric </div></div></div>
</div>
</blockquote></div><br></body></html>