<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Mar 7, 2013, at 1:36 PM, Bill Wendling <<a href="mailto:wendling@apple.com">wendling@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">On Mar 7, 2013, at 12:42 PM, Chad Rosier <<a href="mailto:mcrosier@apple.com">mcrosier@apple.com</a>> wrote:<br><br><blockquote type="cite">Author: mcrosier<br>Date: Thu Mar 7 14:42:17 2013<br>New Revision: 176649<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=176649&view=rev">http://llvm.org/viewvc/llvm-project?rev=176649&view=rev</a><br>Log:<br>[fast-isel] Add support for the expect intrinsic.<br><a href="rdar://13370942">rdar://13370942</a><br><br>Modified:<br> llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp<br> llvm/trunk/test/CodeGen/ARM/fast-isel-intrinsic.ll<br><br>Modified: llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp?rev=176649&r1=176648&r2=176649&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp?rev=176649&r1=176648&r2=176649&view=diff</a><br>==============================================================================<br>--- llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp (original)<br>+++ llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp Thu Mar 7 14:42:17 2013<br>@@ -698,6 +698,11 @@ bool FastISel::SelectCall(const User *I)<br> UpdateValueMap(Call, ResultReg);<br> return true;<br> }<br>+ case Intrinsic::expect: {<br>+// unsigned ResultReg = getRegForValue(Call->getArgOperand(0));<br>+// UpdateValueMap(Call, ResultReg);<br>+// return true;<br>+ }<br> }<br><br></blockquote>?? Why is this all commented out?<br></div></blockquote><div><br></div><div>Opps… I commented out the code to make sure the test failed prior to my change, but then forgot to uncomment them out.. :o/</div><div><br></div><div>Committed revision 176659. Thanks, Bill.</div><br><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">-bw<br><br><blockquote type="cite"> // Usually, it does not make sense to initialize a value,<br><br>Modified: llvm/trunk/test/CodeGen/ARM/fast-isel-intrinsic.ll<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/fast-isel-intrinsic.ll?rev=176649&r1=176648&r2=176649&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/fast-isel-intrinsic.ll?rev=176649&r1=176648&r2=176649&view=diff</a><br>==============================================================================<br>--- llvm/trunk/test/CodeGen/ARM/fast-isel-intrinsic.ll (original)<br>+++ llvm/trunk/test/CodeGen/ARM/fast-isel-intrinsic.ll Thu Mar 7 14:42:17 2013<br>@@ -238,3 +238,15 @@ define void @t7() nounwind ssp {<br> call void @llvm.memcpy.p0i8.p0i8.i32(i8* getelementptr inbounds ([60 x i8]* @temp, i32 0, i32 4), i8* getelementptr inbounds ([60 x i8]* @temp, i32 0, i32 16), i32 3, i32 2, i1 false)<br> ret void<br>}<br>+<br>+define i32 @t8(i32 %x) nounwind {<br>+entry:<br>+; ARM: t8<br>+; ARM-NOT: FastISel missed call: %expval = call i32 @llvm.expect.i32(i32 %x, i32 1)<br>+; THUMB: t8<br>+; THUMB-NOT: FastISel missed call: %expval = call i32 @llvm.expect.i32(i32 %x, i32 1)<br>+ %expval = call i32 @llvm.expect.i32(i32 %x, i32 1)<br>+ ret i32 %expval<br>+}<br>+<br>+declare i32 @llvm.expect.i32(i32, i32) nounwind readnone<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></blockquote></div></blockquote></div><br></body></html>