<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Mar 7, 2013, at 1:44 PM, Chad Rosier <<a href="mailto:mcrosier@apple.com">mcrosier@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Mar 7, 2013, at 1:36 PM, Bill Wendling <<a href="mailto:wendling@apple.com">wendling@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">On Mar 7, 2013, at 12:42 PM, Chad Rosier <<a href="mailto:mcrosier@apple.com">mcrosier@apple.com</a>> wrote:<br><br><blockquote type="cite">Author: mcrosier<br>Date: Thu Mar 7 14:42:17 2013<br>New Revision: 176649<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=176649&view=rev">http://llvm.org/viewvc/llvm-project?rev=176649&view=rev</a><br>Log:<br>[fast-isel] Add support for the expect intrinsic.<br><a href="rdar://13370942">rdar://13370942</a><br><br>Modified:<br> llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp<br> llvm/trunk/test/CodeGen/ARM/fast-isel-intrinsic.ll<br><br>Modified: llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp?rev=176649&r1=176648&r2=176649&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp?rev=176649&r1=176648&r2=176649&view=diff</a><br>==============================================================================<br>--- llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp (original)<br>+++ llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp Thu Mar 7 14:42:17 2013<br>@@ -698,6 +698,11 @@ bool FastISel::SelectCall(const User *I)<br> UpdateValueMap(Call, ResultReg);<br> return true;<br> }<br>+ case Intrinsic::expect: {<br>+// unsigned ResultReg = getRegForValue(Call->getArgOperand(0));<br>+// UpdateValueMap(Call, ResultReg);<br>+// return true;<br>+ }<br> }<br><br></blockquote>?? Why is this all commented out?<br></div></blockquote><div><br></div><div>Opps… I commented out the code to make sure the test failed prior to my change, but then forgot to uncomment them out.. :o/</div></div></div></blockquote></div><br><div>Not your fault. This is 100% llvm-lit's fault. I've never figured out how to use it in a normal workflow:</div><div><br></div><div>Clean build in /clean</div><div>Fix in /fix</div><div>Implement test case in /fix</div><div>Verify that test fails with /clean</div><div><br></div><div>I end up copying test files around and have to remember to clean them up. It's super irritating, but I don't see myself diving into lit any time soon, and I know it's easier to complain than fix it because the tool and test configurations are interrelated. Hence:</div><div><br></div><div><div>PR15218: llvm-lit should use its current location as the tools-path</div><div>PR15473: llvm-lit should respect the test file's path from the command line.</div></div><div><br></div><div>-Andy</div></body></html>