<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">I think that SROA assumes that vector operands are not bitpacked. Can you check if we can SROA the packed vectors ?<div><br></div><div>Thanks,</div><div>Nadav <div><br><div><div>On Mar 6, 2013, at 9:35 AM, Michael Liao <<a href="mailto:michael.liao@intel.com">michael.liao@intel.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">ping again. - michael<br><br>On Fri, 2013-03-01 at 00:35 -0600, Hal Finkel wrote:<br><blockquote type="cite">----- Original Message -----<br><blockquote type="cite">From: "Michael Liao" <<a href="mailto:michael.liao@intel.com">michael.liao@intel.com</a>><br>To: <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>Sent: Thursday, February 28, 2013 11:13:30 PM<br>Subject: [PATCH] Fix PR15131<br><br>Hi All,<br><br>The attached patch fixes PR15131 which is caused by mismatching<br>between<br>global vector constant emission logic and vector in-memory<br>representation (bitpacked now.)<br></blockquote><br>+@X = global <4 x i1> <i1 0, i1 1, i1 2, i1 3><br>+@Y = global <4 x i3> <i3 0, i3 1, i3 2, i3 3><br>+@Z = global <5 x i30> <i30 0, i30 1, i30 2, i30 3, i30 4><br>+<br>+; CHECK: byte 10<br>+; CHECK: short 1672<br>+; CHECK: quad 2305843010287435776<br>+; CHECK: quad 288230376353038336<br>+; CHECK: quad 0<br>+; CHECK: quad 0<br><br>Is this really the behavior that we want, or do we only want to bitpack i1 vectors? Or vectors with an element size less than 1 byte? I could be wrong, but I think that at least your last example (<5 x i30>) will break currently-working code that operates on vectors of arbitrarily-sized integers. Duncan?<br><br>-Hal<br><br><blockquote type="cite"><br>Thanks for review<br>- Michael<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br><br></blockquote></blockquote><br><span><0001-Fix-PR15131-part-of-PR1784.patch></span></div></blockquote></div><br></div></div></body></html>