<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Mar 1, 2013 at 4:51 PM, Michael Gottesman <span dir="ltr"><<a href="mailto:mgottesman@apple.com" target="_blank">mgottesman@apple.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">(I think Eli went home for the day. Reverting since it is a phase 1 make check failure…)<div>

<div class="h5"><div><br></div></div></div></div></blockquote><div><br></div><div>Sorry about that, and thanks for reverting. It's  a very low-priority change, I'll rewrite it to be more robust in the beginning of the week.<br>

<br>Eli<br><br></div><div><br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div class="h5"><div><div><div>On Mar 1, 2013, at 4:04 PM, Michael Gottesman <<a href="mailto:mgottesman@apple.com" target="_blank">mgottesman@apple.com</a>> wrote:</div>

<br><blockquote type="cite"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div>Your commit broke a buildbot:</div><div><br>

</div><div><a href="http://lab.llvm.org:8013/builders/clang-x86_64-darwin11-nobootstrap-RA/builds/2137" target="_blank">http://lab.llvm.org:8013/builders/clang-x86_64-darwin11-nobootstrap-RA/builds/2137</a></div><div><br>

</div><div>Michael</div><br><div><div>On Mar 1, 2013, at 1:34 PM, Eli Bendersky <<a href="mailto:eliben@google.com" target="_blank">eliben@google.com</a>> wrote:</div><br><blockquote type="cite"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">

Author: eliben<br>Date: Fri Mar  1 15:34:37 2013<br>New Revision: 176381<br><br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project?rev=176381&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=176381&view=rev</a><br>

Log:<br>Rewrite a test to count emitted instructions without using -stats<br><br>Also removed the comments of "should produce..." because they completely<br>don't match the actually produced output.<br><br>
<br>
Modified:<br>   llvm/trunk/test/CodeGen/Thumb/iabs.ll<br><br>Modified: llvm/trunk/test/CodeGen/Thumb/iabs.ll<br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Thumb/iabs.ll?rev=176381&r1=176380&r2=176381&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Thumb/iabs.ll?rev=176381&r1=176380&r2=176381&view=diff</a><br>

==============================================================================<br>--- llvm/trunk/test/CodeGen/Thumb/iabs.ll (original)<br>+++ llvm/trunk/test/CodeGen/Thumb/iabs.ll Fri Mar  1 15:34:37 2013<br>@@ -1,22 +1,20 @@<br>

-; RUN: llc < %s -march=thumb -stats 2>&1 | \<br>-; RUN:   grep "4 .*Number of machine instrs printed"<br>-<br>-;; Integer absolute value, should produce something as good as:<br>-;; Thumb:<br>-;;   movs r0, r0<br>

-;;   bpl<br>-;;   rsb r0, r0, #0 (with opitmization, bpl + rsb is if-converted into rsbmi)<br>-;;   bx lr<br>+; RUN: llc < %s -march=thumb -filetype=obj -o %t.o<br>+; RUN: llvm-objdump -disassemble -arch=thumb %t.o | FileCheck %s<br>

<br>define i32 @test(i32 %a) {<br>        %tmp1neg = sub i32 0, %a<br>        %b = icmp sgt i32 %a, -1<br>        %abs = select i1 %b, i32 %a, i32 %tmp1neg<br>        ret i32 %abs<br>-; CHECK:  movs r0, r0<br>-; CHECK:  bpl<br>

-; CHECK:  rsb r0, r0, #0<br>-; CHECK:  bx lr<br>-}<br><br>+; This test just checks that 4 instructions were emitted<br>+<br>+; CHECK:      {{^.text:}}<br>+; CHECK-NEXT: 0:<br>+; CHECK-NEXT: 2:<br>+; CHECK-NEXT: 4:<br>+; CHECK-NEXT: 6:<br>

+<br>+; CHECK-NOT: 8:<br>+}<br><br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div>

</blockquote></div><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div>

</blockquote></div><br></div></div></div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>