<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">LGTM.<div><br></div><div>What prevented running the test for Thumb1?</div><div><br><div><div>On Mar 1, 2013, at 10:09 AM, Chad Rosier <<a href="mailto:mcrosier@apple.com">mcrosier@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">All,<br>The attached patch adds support for using non-pic code for thumb1 and arm when emitting the sjlj<br>dispatch code. As far as I can tell the thumb2 code is behaving as expected. I was able to compile<br>and run the attached test case for arm. Unfortunately, I wasn't able to do the same for thumb1. The<br>changes are mechanically equivalent between arm and thumb1, but I'd still prefer to have the code<br>reviewed.<br><br>Regards,<br> Chad<br><br><span><arm-dispcont-nonpic.patch></span></div></blockquote></div><br></div></body></html>