<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Thanks Shuxin,<div><br></div><div>Committed: r176300.</div><div><br></div><div><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-Quentin</div>
</div>
<br><div><div>On Feb 28, 2013, at 11:47 AM, Shuxin Yang <<a href="mailto:shuxin.llvm@gmail.com">shuxin.llvm@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div bgcolor="#FFFFFF" text="#000000" style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">Hi, Quentin:<br><br> That stupid bug was created by me. Your change looks great. Please commit.<span class="Apple-converted-space"> </span><br><br>Shuxin<br><br><br><div class="moz-cite-prefix">On 2/28/13 11:43 AM, Quentin Colombet wrote:<br></div><blockquote cite="mid:EDF6A12E-ADE2-4E81-9EB6-BB9D24A46E1F@apple.com" type="cite"><pre wrap="">Hi,
I've attached a patch that fixes a bug in instcombine for fmul in fast math mode.
The instcombine recognized pattern looks like:
a = b * c
d = a +/- Cst
or
a = b * c
d = Cst +/- a
The actual code inverts the operand of the resulting add/sub instruction. This leads to incorrect code when the resulting operation is fsub.
The fix is straight forward. The new first operand is created form the old first operand and the new second operand is created from the old second operand. Previously, this was inverted.
The patch also contains a test case.
Thanks for the reviews.
Quentin
PS: I've also fixed the consistency of a comment to reflect the actual variable naming.
</pre><br><fieldset class="mimeAttachmentHeader"></fieldset><br><pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre></blockquote><br></div><br class="Apple-interchange-newline"></blockquote></div><br></div></body></html>