<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body text="#000000" bgcolor="#ffffff">
Hi ,<br>
<br>
Can someone commit the attatched (cleanup) patch for r175528?<br>
<br>
Thanks,<br>
yiannis<br>
<br>
On 02/25/2013 08:11 PM, Dmitry Babokin wrote:
<blockquote
cite="mid:CACRFwujM+R63ZT5CGE5DTccXB+DhOZ47GmCDrH4Qhcu+v-cVfg@mail.gmail.com"
type="cite">
<div>Yiannis, Pedro,</div>
<div><br>
</div>
I'm not an expert here. Taking closer look I see that it makes sense to
do this cleanup job in doFinalization() of the pass, which requested GC
info. So the current fix seems to be ok and all external clients will
need to do cleanup directly doing the same jobs as
Printer::doFinalization() does now.
<div><br>
</div>
<div>By the way, I've just noticed that comments for
GCModuleInfo::clear() also needs to be updated, as it mentions deleter
pass.<br>
<br>
<div class="gmail_quote">On Mon, Feb 25, 2013 at 9:55 PM, Yiannis
Tsiouris <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:gtsiour@softlab.ntua.gr" target="_blank">gtsiour@softlab.ntua.gr</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi
Dmitry,
<div class="im"><br>
<br>
On 02/23/13 19:10, Dmitry Babokin wrote:<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
What's about the usage case, when LLVM is used as a library and the
user implements its custom pass, which dump the code (implemented as a
FunctionPass, but not as Printer)?<br>
</blockquote>
</div>
Hm, I haven't thought of that... I'll take a better look and try to
find a more suitable solution. Any suggestion is more than welcome! :-)
<div class="im"><br>
<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
You also missed in your changes the declaration of
llvm::createGCInfoDeleter() in include/llvm/CodeGen/Passes.h<br>
</blockquote>
</div>
Oops, sorry! I suppose I missed that! Pedro, will you take care of that
(by just removing it) or should I sent a trivial fix in llvm-commits
(where I don't have direct commit access)?<br>
</blockquote>
</div>
</div>
</blockquote>
<pre class="moz-signature" cols="80">--
Yiannis Tsiouris
Ph.D. student,
Software Engineering Laboratory,
National Technical University of Athens
WWW: <a class="moz-txt-link-freetext" href="http://www.softlab.ntua.gr/~gtsiour">http://www.softlab.ntua.gr/~gtsiour</a></pre>
</body>
</html>