<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Feb 25, 2013, at 6:33 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><br class="Apple-interchange-newline"><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">On Mon, Feb 25, 2013 at 5:05 PM, Chad Rosier<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:mcrosier@apple.com" target="_blank">mcrosier@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto;">Author: mcrosier<br>Date: Mon Feb 25 19:05:31 2013<br>New Revision: 176066<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=176066&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=176066&view=rev</a><br>Log:<br>[fast-isel] Make sure the FastLowerArguments function checks to make sure the<br>arguments type is a simple type.<br><a href="rdar://13290455">rdar://13290455</a><br></blockquote><div><br></div><div>Test case?</div></div></blockquote><div><br></div><div>David,</div><div>I'm not aware of an easy way to test this.</div><div><br></div><div><div>; RUN: not llc < %s -fast-isel -fast-isel-abort -fast-isel-abort-args -verify-machineinstrs -mtriple=x86_64-apple-darwin10</div><div><br></div><div>; Abort because we don't know how to handle non-simple type i31.</div><div>define i31 @t1(i31 %a, i31 %b, i31 %c) {</div><div>entry:</div><div> %add = add nsw i31 %b, %a</div><div> %add1 = add nsw i31 %add, %c</div><div> ret i31 %add1</div><div>}</div><div><br></div><div>The above test case will exercise the issue, but results in llc aborting and the 'not' on the run line doesn't have the correct effect.</div></div><div><br></div><div> Chad</div><div><br></div><blockquote type="cite"><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><div> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><br>Modified:<br> <span class="Apple-converted-space"> </span>llvm/trunk/lib/Target/ARM/ARMFastISel.cpp<br> <span class="Apple-converted-space"> </span>llvm/trunk/lib/Target/X86/X86FastISel.cpp<br><br>Modified: llvm/trunk/lib/Target/ARM/ARMFastISel.cpp<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMFastISel.cpp?rev=176066&r1=176065&r2=176066&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMFastISel.cpp?rev=176066&r1=176065&r2=176066&view=diff</a><br>==============================================================================<br>--- llvm/trunk/lib/Target/ARM/ARMFastISel.cpp (original)<br>+++ llvm/trunk/lib/Target/ARM/ARMFastISel.cpp Mon Feb 25 19:05:31 2013<br>@@ -2922,6 +2922,7 @@ bool ARMFastISel::FastLowerArguments() {<br> return false;<br><br> EVT ArgVT = TLI.getValueType(ArgTy);<br>+ if (!ArgVT.isSimple()) return false;<br> switch (ArgVT.getSimpleVT().SimpleTy) {<br> case MVT::i8:<br> case MVT::i16:<br><br>Modified: llvm/trunk/lib/Target/X86/X86FastISel.cpp<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FastISel.cpp?rev=176066&r1=176065&r2=176066&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FastISel.cpp?rev=176066&r1=176065&r2=176066&view=diff</a><br>==============================================================================<br>--- llvm/trunk/lib/Target/X86/X86FastISel.cpp (original)<br>+++ llvm/trunk/lib/Target/X86/X86FastISel.cpp Mon Feb 25 19:05:31 2013<br>@@ -1555,6 +1555,7 @@ bool X86FastISel::FastLowerArguments() {<br> return false;<br><br> EVT ArgVT = TLI.getValueType(ArgTy);<br>+ if (!ArgVT.isSimple()) return false;<br> switch (ArgVT.getSimpleVT().SimpleTy) {<br> case MVT::i32:<br> case MVT::i64:<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></blockquote></div></blockquote></div><br></body></html>