Thanks! Applied to master.<br><br>Thanks<br><br>Galina<br><br><div class="gmail_quote">On Mon, Feb 25, 2013 at 10:04 AM, Malea, Daniel <span dir="ltr"><<a href="mailto:daniel.malea@intel.com" target="_blank">daniel.malea@intel.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div link="blue" vlink="purple" lang="EN-US">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">My bad; it was a missing import.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Should be fixed in 176030 … let me know if you notice any other problems!<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thanks,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Dan<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Galina Kistanova [mailto:<a href="mailto:gkistanova@gmail.com" target="_blank">gkistanova@gmail.com</a>]
<br>
<b>Sent:</b> Monday, February 25, 2013 1:01 PM<br>
<b>To:</b> Malea, Daniel<br>
<b>Cc:</b> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<b>Subject:</b> Re: [zorg] r176028 - Update LLDB builder to parse test results<u></u><u></u></span></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">Hi Daniel,<br>
<br>
Got an exception on this change:<br>
exceptions.NameError: global name 'LitTestCommand' is not defined<br>
<br>
Please have a look.<br>
<br>
Thanks<br>
<br>
Galina<br>
<br>
<br>
<br>
--- <exception caught here> ---<br>
File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", line 545, in _runCallbacks<br>
current.result = callback(current.result, *args, **kw)<br>
File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/master.py", line 226, in do_load<br>
exec f in localDict<br>
File "/Volumes/Macintosh HD2/llvm.buildmaster/zorg/buildbot/osuosl/master/master.cfg", line 72, in <module><br>
c['builders'] = builders = list(config.builders.get_builders())<br>
File "/Volumes/Macintosh HD2/llvm.buildmaster/zorg/buildbot/osuosl/master/config/builders.py", line 660, in get_builders<br>
for b in _get_lldb_builders():<br>
File "/Volumes/Macintosh HD2/llvm.buildmaster/zorg/buildbot/osuosl/master/config/builders.py", line 563, in _get_lldb_builders<br>
env={'PATH':'/home/llvmbb/bin/clang-latest/bin:/home/llvmbb/bin:/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games'})},<br>
File "/Volumes/Macintosh HD2/llvm.buildmaster/zorg/zorg/buildbot/builders/LLDBBuilder.py", line 91, in getLLDBBuildFactory<br>
f.addStep(LitTestCommand(name="test lldb",<br>
exceptions.NameError: global name 'LitTestCommand' is not defined<u></u><u></u></p>
<div>
<p class="MsoNormal">On Mon, Feb 25, 2013 at 8:31 AM, Daniel Malea <<a href="mailto:daniel.malea@intel.com" target="_blank">daniel.malea@intel.com</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal">Author: dmalea<br>
Date: Mon Feb 25 10:31:42 2013<br>
New Revision: 176028<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=176028&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=176028&view=rev</a><br>
Log:<br>
Update LLDB builder to parse test results<br>
- use LitTestCommand instead of ShellCommand to parse clang-like test result output<br>
<br>
<br>
Modified:<br>
zorg/trunk/zorg/buildbot/builders/LLDBBuilder.py<br>
<br>
Modified: zorg/trunk/zorg/buildbot/builders/LLDBBuilder.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/LLDBBuilder.py?rev=176028&r1=176027&r2=176028&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/LLDBBuilder.py?rev=176028&r1=176027&r2=176028&view=diff</a><br>
==============================================================================<br>
--- zorg/trunk/zorg/buildbot/builders/LLDBBuilder.py (original)<br>
+++ zorg/trunk/zorg/buildbot/builders/LLDBBuilder.py Mon Feb 25 10:31:42 2013<br>
@@ -87,22 +87,13 @@ def getLLDBBuildFactory(triple, outOfDir<br>
haltOnFailure=True,<br>
workdir=llvm_objdir))<br>
<br>
- # The tests are hanging on Linux at the moment due to some "expect"<br>
- # functionality not happening correctly. For now we will stub out the tests<br>
- # so we can at least get builds running and reinstate the tests later.<br>
-<br>
- # Fixup file needed for tests<br>
- # f.addStep(ShellCommand(name"copy-gnu_libstdcpp.py",<br>
- # command="cp tools/lldb/examples/synthetic/gnu_libstdcpp.py Debug+Asserts/bin",<br>
- # workdir=llvm_srcdir))<br>
-<br>
# Test.<br>
- f.addStep(ShellCommand(name="test",<br>
- command=['nice', '-n', '10',<br>
- 'make'],<br>
- haltOnFailure=True, description="test lldb",<br>
- env=env,<br>
- workdir='%s/tools/lldb/test' % llvm_objdir))<br>
+ f.addStep(LitTestCommand(name="test lldb",<br>
+ command=['nice', '-n', '10',<br>
+ 'make'],<br>
+ description="test lldb",<br>
+ env=env,<br>
+ workdir='%s/tools/lldb/test' % llvm_objdir))<br>
<br>
return f<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div></div></div>
</div>
</blockquote></div><br>