<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Feb 21, 2013 at 6:35 AM, Bill Schmidt <span dir="ltr"><<a href="mailto:wschmidt@linux.vnet.ibm.com" target="_blank">wschmidt@linux.vnet.ibm.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: wschmidt<br>
Date: Thu Feb 21 08:35:42 2013<br>
New Revision: 175739<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=175739&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=175739&view=rev</a><br>
Log:<br>
Code review cleanup for r175697<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/PowerPC/PPCISelDAGToDAG.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/PowerPC/PPCISelDAGToDAG.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCISelDAGToDAG.cpp?rev=175739&r1=175738&r2=175739&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCISelDAGToDAG.cpp?rev=175739&r1=175738&r2=175739&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Target/PowerPC/PPCISelDAGToDAG.cpp (original)<br>
+++ llvm/trunk/lib/Target/PowerPC/PPCISelDAGToDAG.cpp Thu Feb 21 08:35:42 2013<br>
@@ -1524,20 +1524,16 @@ void PPCDAGToDAGISel::PostprocessISelDAG<br>
     // If the relocation information isn't already present on the<br>
     // immediate operand, add it now.<br>
     if (ReplaceFlags) {<br>
-      GlobalAddressSDNode *GA = dyn_cast<GlobalAddressSDNode>(ImmOpnd);<br>
-<br>
-      if (GA) {<br>
+      if (GlobalAddressSDNode *GA = dyn_cast<GlobalAddressSDNode>(ImmOpnd)) {<br>
         DebugLoc dl = GA->getDebugLoc();<br>
         const GlobalValue *GV = GA->getGlobal();<br>
         ImmOpnd = CurDAG->getTargetGlobalAddress(GV, dl, MVT::i64, 0, Flags);<br>
-      } else {<br>
-        ConstantPoolSDNode *CP = dyn_cast<ConstantPoolSDNode>(ImmOpnd);<br>
-        if (CP) {<br>
-          const Constant *C = CP->getConstVal();<br>
-          ImmOpnd = CurDAG->getTargetConstantPool(C, MVT::i64,<br>
-                                                  CP->getAlignment(),<br>
-                                                  0, Flags);<br>
-        }<br>
+      }<br>
+      else if (ConstantPoolSDNode *CP = dyn_cast<ConstantPoolSDNode>(ImmOpnd)) {<br></blockquote><div><br></div><div style>Still got a }\nelse here that's not usually the way we write it. Might I suggest clang-format as a good place to start? It does wrap a few things strangely (bugs welcome) but should get you in the ballpark pretty quickly.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+        const Constant *C = CP->getConstVal();<br>
+        ImmOpnd = CurDAG->getTargetConstantPool(C, MVT::i64,<br>
+                                                CP->getAlignment(),<br>
+                                                0, Flags);<br>
       }<br>
     }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>