<div>Ok. I committed r175571 which hopefully restores the earlier behavior, though I am unable to verify it.<br><div><div><br></div><div>Dan</div><div><br><div class="gmail_quote">On Tue, Feb 19, 2013 at 2:16 PM, Anna Zaks <span dir="ltr"><<a href="mailto:ganna@apple.com" target="_blank">ganna@apple.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Dan,<div><br></div><div>Looks like this is breaking our internal MSVC builder:</div>
<div>
<pre style="font-family:'Courier New',courier,monotype;font-size:medium"><span>3>..\..\..\lib\Support\MemoryBuffer.cpp(328) : error C3861: 'S_ISREG': identifier not found
3>..\..\..\lib\Support\MemoryBuffer.cpp(328) : error C3861: 'S_ISBLK': identifier not found</span></pre><span><font color="#888888"><div>Anna.</div></font></span><div><div><div><div>On Feb 19, 2013, at 11:36 AM, Dan Gohman <<a href="mailto:dan433584@gmail.com" target="_blank">dan433584@gmail.com</a>> wrote:</div>

<br><blockquote type="cite">Author: djg<br>Date: Tue Feb 19 13:36:55 2013<br>New Revision: 175549<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=175549&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=175549&view=rev</a><br>

Log:<br>Whitelist files and block devices instead of blacklisting fifos and<br>character devices.<br><br>Modified:<br>    llvm/trunk/lib/Support/MemoryBuffer.cpp<br><br>Modified: llvm/trunk/lib/Support/MemoryBuffer.cpp<br>

URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/MemoryBuffer.cpp?rev=175549&r1=175548&r2=175549&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/MemoryBuffer.cpp?rev=175549&r1=175548&r2=175549&view=diff</a><br>

==============================================================================<br>--- llvm/trunk/lib/Support/MemoryBuffer.cpp (original)<br>+++ llvm/trunk/lib/Support/MemoryBuffer.cpp Tue Feb 19 13:36:55 2013<br>@@ -322,9 +322,10 @@ error_code MemoryBuffer::getOpenFile(int<br>

         return error_code(errno, posix_category());<br>       }<br><br>-      // If this is a named pipe or character device, we can't trust the size.<br>-      // Create the memory buffer by copying off the stream.<br>

-      if (S_ISFIFO(FileInfo.st_mode) || S_ISCHR(FileInfo.st_mode)) {<br>+      // If this not a file or a block device (e.g. it's a named pipe<br>+      // or character device), we can't trust the size. Create the memory<br>

+      // buffer by copying off the stream.<br>+      if (!S_ISREG(FileInfo.st_mode) && !S_ISBLK(FileInfo.st_mode)) {<br>         return getMemoryBufferForStream(FD, Filename, result);<br>       }<br><br><br><br>
_______________________________________________<br>
llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>

</blockquote></div><br></div></div></div></div></blockquote></div><br></div></div>
</div>