<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Feb 19, 2013 at 3:15 AM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="im">On Mon, Feb 18, 2013 at 5:47 AM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><div class="im">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: kcc<br>
Date: Mon Feb 18 07:47:02 2013<br>
New Revision: 175442<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=175442&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=175442&view=rev</a><br>
Log:<br>
[asan] revert r175266 as it breaks code with packed structures. supporting long double will require a more general solution<br></blockquote><div><br></div></div><div>Thanks for tracking this down!</div></div></div></div>
</blockquote><div><br></div><div style>that was samsonov@ (kudos!)</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div><br></div><div>
Can you add a simple regression test for the packed structs? (Or maybe you did and I just missed the commit?)</div></div></div></div></blockquote><div><br></div><div style>There is a test for long doubles which tests for the same thing. </div>
<div style>I am planing to actually fix both long doubles and packed structures (have a patch already) and add positive tests. </div><div style><br></div><div style>--kcc </div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp<br>
llvm/trunk/test/Instrumentation/AddressSanitizer/basic.ll<br>
<br>
Modified: llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp?rev=175442&r1=175441&r2=175442&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp?rev=175442&r1=175441&r2=175442&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp Mon Feb 18 07:47:02 2013<br>
@@ -639,7 +639,7 @@ void AddressSanitizer::instrumentMop(Ins<br>
Type *OrigTy = cast<PointerType>(OrigPtrTy)->getElementType();<br>
<br>
assert(OrigTy->isSized());<br>
- uint32_t TypeSize = TD->getTypeAllocSizeInBits(OrigTy);<br>
+ uint32_t TypeSize = TD->getTypeStoreSizeInBits(OrigTy);<br>
<br>
if (TypeSize != 8 && TypeSize != 16 &&<br>
TypeSize != 32 && TypeSize != 64 && TypeSize != 128) {<br>
<br>
Modified: llvm/trunk/test/Instrumentation/AddressSanitizer/basic.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Instrumentation/AddressSanitizer/basic.ll?rev=175442&r1=175441&r2=175442&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Instrumentation/AddressSanitizer/basic.ll?rev=175442&r1=175441&r2=175442&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/Instrumentation/AddressSanitizer/basic.ll (original)<br>
+++ llvm/trunk/test/Instrumentation/AddressSanitizer/basic.ll Mon Feb 18 07:47:02 2013<br>
@@ -96,5 +96,5 @@ entry:<br>
}<br>
<br>
; CHECK: LongDoubleTest<br>
-; CHECK: __asan_report_store16<br>
+; CHECK-NOT: __asan_report_store16<br>
; CHECK: ret void<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div>