<div dir="ltr">LGTM</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Feb 17, 2013 at 3:15 PM, Jakub Staszak <span dir="ltr"><<a href="mailto:kubastaszak@gmail.com" target="_blank">kubastaszak@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This patch reduces reinterpret_cast usage and changes it to llvm::cast.<br>
Also GetElementPtrInst::getType() method wasn't correct, because it can return VectorType or PointerType.<br>
<br>
I couldn't get any testcase because VectorType and PointerType are both SequentialType, so everything worked fine.<br>
<br>
Is it OK to commit?<br>
<br>
Thanks!<br>
- Kuba<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>