<html><head></head><body bgcolor="#FFFFFF"><div><br></div><div>On Feb 15, 2013, at 5:48 PM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Feb 15, 2013 at 5:25 PM, Chad Rosier <span dir="ltr"><<a href="mailto:mcrosier@apple.com" target="_blank">mcrosier@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: mcrosier<br>
Date: Fri Feb 15 19:25:28 2013<br>
New Revision: 175334<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=175334&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=175334&view=rev</a><br>
Log:<br>
[ms-inline asm] Do not omit the frame pointer if we have ms-inline assembly.<br>
<br>
If the frame pointer is omitted, and any stack changes occur in the inline<br>
assembly, e.g.: "pusha", then any C local variable or C argument references<br>
will be incorrect.<br>
<br>
I pass no judgement on anyone who would do such a thing. ;)<br>
<a href="rdar://13218191">rdar://13218191</a><br></blockquote><div><br></div><div style="">Should be no different than anything in any other asm block?</div><div style=""><br></div><div style="">I.e. why conditionalize it? </div></div></div></div></div></blockquote><div><br></div><div>As in why do it for MS-style only? AFAIK, the MSVC compiler has the same behavior (i.e., it always omits a frame pointer). As for GNU-style assembly, no one has complained, so why change something that doesn't appear to be broken.</div><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div style="">Or why do it at all?</div></div></div></div></div></blockquote><div><br></div><div>Because I've had external developers complain and because of the MSVC compatibility issue (which could be a correctness issue depending on how crazy the developer wants to get; again, no judgement ;).</div><div><br></div><div> Chad</div><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div style="">-eric </div></div></div></div>
</div></blockquote></body></html>