<div dir="ltr">Yea, noticed this too. <div>The fix for the test was in my workspace, but is not yet committed (<a href="http://llvm-reviews.chandlerc.com/D390" target="_blank" style="font-size:13px;font-family:arial,sans-serif">http://llvm-reviews.chandlerc.com/D390</a>).</div>
<div style>Unless I get an approval quickly I'll revert this test. </div><div style><br></div><div style>--kcc </div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Feb 13, 2013 at 10:07 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div class="im">On Tue, Feb 12, 2013 at 10:07 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br>
</div><div><div class="h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: kcc<br>
Date: Wed Feb 13 00:07:50 2013<br>
New Revision: 175037<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=175037&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=175037&view=rev</a><br>
Log:<br>
[tsan] simplify tsan-vs-gvn test since gvn vs tsan is now fixed; fix lint<br>
<br>
Modified:<br>
compiler-rt/trunk/lib/asan/asan_interface_internal.h<br>
compiler-rt/trunk/lib/tsan/lit_tests/tsan-vs-gvn.cc<br>
<br>
Modified: compiler-rt/trunk/lib/asan/asan_interface_internal.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_interface_internal.h?rev=175037&r1=175036&r2=175037&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_interface_internal.h?rev=175037&r1=175036&r2=175037&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/asan/asan_interface_internal.h (original)<br>
+++ compiler-rt/trunk/lib/asan/asan_interface_internal.h Wed Feb 13 00:07:50 2013<br>
@@ -23,7 +23,7 @@ extern "C" {<br>
// This function should be called at the very beginning of the process,<br>
// before any instrumented code is executed and before any call to malloc.<br>
// Everytime the asan ABI changes we also change the version number in this<br>
- // name. Objects build with incompatible asan ABI version<br>
+ // name. Objects build with incompatible asan ABI version<br>
// will not link with run-time.<br>
void __asan_init_v1() SANITIZER_INTERFACE_ATTRIBUTE;<br>
#define __asan_init __asan_init_v1<br>
<br>
Modified: compiler-rt/trunk/lib/tsan/lit_tests/tsan-vs-gvn.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/lit_tests/tsan-vs-gvn.cc?rev=175037&r1=175036&r2=175037&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/lit_tests/tsan-vs-gvn.cc?rev=175037&r1=175036&r2=175037&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/tsan/lit_tests/tsan-vs-gvn.cc (original)<br>
+++ compiler-rt/trunk/lib/tsan/lit_tests/tsan-vs-gvn.cc Wed Feb 13 00:07:50 2013<br>
@@ -1,5 +1,6 @@<br>
-// RUN: %clangxx_tsan -O1 %s -o %t && %t 2>&1 | FileCheck %s --check-prefix=CHECK_O1<br>
-// ---RUN: %clangxx_tsan -O2 %s -o %t && %t 2>&1 | FileCheck %s --check-prefix=CHECK_O2<br>
+// RUN: %clangxx_tsan -O1 %s -o %t && %t 2>&1 | FileCheck %s<br>
+// RUN: %clangxx_tsan -O2 %s -o %t && %t 2>&1 | FileCheck %s<br>
+// RUN: %clangxx_tsan -O3 %s -o %t && %t 2>&1 | FileCheck %s<br>
//<br>
// Check that load widening is not tsan-hostile.<br>
#include <pthread.h><br>
@@ -33,8 +34,5 @@ int main() {<br>
printf("PASS\n");<br>
}<br>
<br>
-// FIXME: currently, this test fails at -O2 (reports false positive).<br>
-// CHECK_O2: WARNING: ThreadSanitizer: data race<br>
-<br>
-// CHECK_O1: PASS<br>
-// CHECK_O1-NOT: WARNING: ThreadSanitizer: data race<br>
+// CHECK-NOT: WARNING: ThreadSanitizer: data race<br>
+// CHECK: PASS<br></blockquote><div><br></div></div></div><div class="im"><div style="font-family:monospace">Seeing failures of this test on my ubuntu machine:<br><br> llvm/src/projects/compiler-rt/lib/<span>tsan</span>/lit_tests/<span>tsan</span>-<span>vs</span>-<span>gvn</span>.<span>cc</span>:38:11: error: expected string not found in input</div>
<div style="font-family:monospace">// CHECK: PASS</div><div style="font-family:monospace"> ^</div><div style="font-family:monospace"><stdin>:1:1: note: scanning from here</div><div style="font-family:monospace">
==================</div><div style="font-family:monospace">^</div><div style="font-family:monospace"><stdin>:2:1: note: possible intended match here</div><div style="font-family:monospace">WARNING: ThreadSanitizer: data race (pid=7350)</div>
<div><span style="font-family:monospace">^</span></div><div><span style="font-family:monospace"><br></span></div></div><div>(sorry for the duplicate reply, Kostya, accidentally replied directly the first time)</div></div>
</div></div>
</blockquote></div><br></div>