<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 2/13/2013 7:55 PM, Chris Lattner
wrote:<br>
</div>
<blockquote
cite="mid:2EF6D56E-B285-4F95-9AE1-19111916272F@apple.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<br>
<div>
<div>On Feb 13, 2013, at 3:59 AM, Moritz Maxeiner <<a
moz-do-not-send="true"
href="mailto:moritzmaxeiner@googlemail.com">moritzmaxeiner@googlemail.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div text="#000000" bgcolor="#FFFFFF">
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 14px;" lang="x-western">On 2/13/2013 5:46 AM,
Chris Lattner wrote: <br>
<blockquote type="cite" style="">On Feb 10, 2013, at 9:13
AM, Moritz Maxeiner <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:moritzmaxeiner@googlemail.com"><moritzmaxeiner@googlemail.com></a>
wrote: <br>
<br>
<blockquote type="cite" style="">Add two new functions
to the C API: <br>
<br>
LLVMCreateMemoryBufferWithMemoryRange - exposes
MemoryBuffer::getMemBuffer <br>
LLVMCreateMemoryBufferWithMemoryRangeCopy - exposes
MemoryBuffer::getMemBufferCopy <br>
</blockquote>
These new APIs should take a "const char*" + length.
The memory buffer may have embedded nul's in it. <br>
</blockquote>
<br>
Of course, my bad. I assume the BufferName may not contain
nuls, so I added the lengths only for the <br>
InputData, if that is not the case - i.e. the BufferName
may contain nuls - I'll change that as well. <br>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>LGTM!</div>
<div><br>
</div>
<div>-Chris</div>
<div><br>
</div>
</div>
</blockquote>
<br>
Awesome!<br>
So... anything else that I need to/should/can do to get this
committed?<br>
"Developer Policy" - "Making a Patch" more or less only states that
commits have to be reviewed before committing them,<br>
not really who I should talk to for the actual committing.<br>
Also, will this require a test-case? The developer policy does state
that every new feature needs a test-case,<br>
but technically this is just wrapping existing C++ calls to C calls,
so not really a new feature for LLVM per se, only<br>
for the C API.<br>
<br>
-- Moritz<br>
</body>
</html>