<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"><base href="x-msg://6736/"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jan 31, 2013, at 2:54 PM, "Nowicki, Tyler" <<a href="mailto:tyler.nowicki@intel.com">tyler.nowicki@intel.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div lang="EN-US" link="blue" vlink="purple" style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div class="WordSection1" style="page: WordSection1; "><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; ">Hi,<o:p></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; "><o:p> </o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; ">This patch aims to improve compile time performance by replacing a sequential search over an std::vector in the function getVTList() with a look up into a SmallVector where the index is calculated by hashing the input VTs and a sequential search through a smaller VT bucket.<o:p></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; "><o:p> </o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; ">This patch is part of a series of compile time improvements. Although these were originally produced by our colleague Wan Xiaofei, our team consisting of<span class="Apple-converted-space"> </span><a href="mailto:preston.gurd@intel.com" style="color: purple; text-decoration: underline; ">preston.gurd@intel.com</a>;<a href="mailto:sriram.murali@intel.com" style="color: purple; text-decoration: underline; ">sriram.murali@intel.com</a><span class="Apple-converted-space"> </span>and myself, are assuming all responsibility for this work.</div></div></div></blockquote><div><br></div>Hi Tyler,</div><div><br></div><div>Marking stuff const is obvious, please commit that. For the actual algorithm here, have you considered using a FoldingSet or a hash table of some sort to unique the lists instead of switching the order of the linear scan?</div><div><br></div><div>-Chris</div><div><br></div></body></html>