<p dir="ltr"><br>
On Feb 10, 2013 2:15 AM, "Bill Wendling" <<a href="mailto:isanbard@gmail.com">isanbard@gmail.com</a>> wrote:<br>
><br>
> Author: void<br>
> Date: Sun Feb 10 04:13:23 2013<br>
> New Revision: 174834<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=174834&view=rev">http://llvm.org/viewvc/llvm-project?rev=174834&view=rev</a><br>
> Log:<br>
> Handle string attributes in the AttrBuilder.</p>
<p dir="ltr">Tests? (This and your next commit)</p>
<p dir="ltr">><br>
> Modified:<br>
>     llvm/trunk/lib/IR/Attributes.cpp<br>
><br>
> Modified: llvm/trunk/lib/IR/Attributes.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Attributes.cpp?rev=174834&r1=174833&r2=174834&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Attributes.cpp?rev=174834&r1=174833&r2=174834&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/lib/IR/Attributes.cpp (original)<br>
> +++ llvm/trunk/lib/IR/Attributes.cpp Sun Feb 10 04:13:23 2013<br>
> @@ -879,7 +879,11 @@ AttrBuilder &AttrBuilder::addAttribute(A<br>
>  }<br>
><br>
>  AttrBuilder &AttrBuilder::addAttribute(Attribute Attr) {<br>
> -  // FIXME: Handle string attributes.<br>
> +  if (Attr.isStringAttribute()) {<br>
> +    addAttribute(Attr.getKindAsString(), Attr.getValueAsString());<br>
> +    return *this;<br>
> +  }<br>
> +<br>
>    Attribute::AttrKind Kind = Attr.getKindAsEnum();<br>
>    Attrs.insert(Kind);<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</p>