<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">They are related. This one is about modeling the cost of reverse shuffles correctly.<div><br></div><div>I will update the cost of v8i16 and v16i8 when I commit this patch. It all depends which patch goes in first :).</div><div><br></div><div>The code for checking is similar but not the same because they are at different stages of lowering.</div><div><br><div><div><div>On Feb 9, 2013, at 1:37 PM, Renato Golin <<a href="mailto:renato.golin@linaro.org">renato.golin@linaro.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">I'm guessing this could be used in your other patch about detecting reverse stride, are they related or conflicting?<div><br></div><div style="">--renato</div></div><div class="gmail_extra"><br><br><div class="gmail_qu!
ote">
On 8 February 2013 18:40, Arnold Schwaighofer <span dir="ltr"><<a href="mailto:aschwaighofer@apple.com" target="_blank">aschwaighofer@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Updated patch.<br>
<br>
<br><br>
<br>
Thanks<br>
<br>
On Feb 8, 2013, at 11:44 AM, Nadav Rotem <<a href="mailto:nrotem@apple.com">nrotem@apple.com</a>> wrote:<br>
<br>
> LGTM! A few minor comments:<br>
><br>
> There is an extra line break here.<br>
><br>
> +<br>
> +static bool isReverseVectorMask(SmallVector<int, 16> &Mask) {<br>
> + for (unsigned i = 0, MaskSize = Mask.size(); i < MaskSize; ++i)<br>
> + if (Mask[i] != (int)(MaskSize - 1 - i))<br>
> + return false;<br>
> + return true;<br>
> +}<br>
> +<br>
><br>
> We should also check for -1's in the mask.<br>
><br>
> + if (NumVecElems == Mask.size() &&<br>
> + isReverseVectorMask(Mask))<br>
><br>
><br>
> The expression above can fit in one line.<br>
><br>
><br>
> Thanks,<br>
> Nadav<br>
<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div></div></body></html>