<div dir="ltr">On Fri, Feb 8, 2013 at 2:21 PM, Sergei Larin <span dir="ltr"><<a href="mailto:slarin@codeaurora.org" target="_blank" class="cremed">slarin@codeaurora.org</a>></span> wrote:<br><div class="gmail_extra">
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Chandler,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> Thanks for the quick review. Please see if this is better. Thanks again.</span></p>
</div></div></blockquote><div><br></div><div style>Yep.</div><div style><br></div><div style>Whenever I say "LGTM with this tweak" feel free to submit, I can check the tweak it post-commit review.</div><div style>
<br></div><div style>Thanks!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Sergei<u></u><u></u></span></p>
<div class="im"><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:10.5pt;font-family:Consolas;color:#1f497d">---<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1f497d">Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation</span><span style="font-size:10.5pt;font-family:Consolas;color:#1f497d"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p></div><div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div><div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in"><p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Chandler Carruth [mailto:<a href="mailto:chandlerc@google.com" target="_blank" class="cremed">chandlerc@google.com</a>] <br>
<b>Sent:</b> Friday, February 08, 2013 3:38 PM<br><b>To:</b> Sergei Larin<br><b>Cc:</b> Commit Messages and Patches for LLVM<br><b>Subject:</b> Re: [llvm] Implement *BasicBlockPass::createPrinterPass method<u></u><u></u></span></p>
</div></div><div><div class="h5"><p class="MsoNormal"><u></u> <u></u></p><div><p class="MsoNormal">LGTM with one tweak:<u></u><u></u></p><div><p class="MsoNormal"><u></u> <u></u></p></div><div><div><p class="MsoNormal">+ /// createPrintBBPass - Create and return a pass that writes the<u></u><u></u></p>
</div><div><p class="MsoNormal">+ /// BB to the specified raw_ostream.<u></u><u></u></p></div><div><p class="MsoNormal">+ BasicBlockPass *createPrintBBPass(raw_ostream *OS,<u></u><u></u></p></div><div><p class="MsoNormal">
+ bool DeleteStream=false,<u></u><u></u></p></div><div><p class="MsoNormal">+ const std::string &Banner = ""); <u></u><u></u></p></div><div>
<p class="MsoNormal"> } // End llvm namespace<u></u><u></u></p></div></div><div><p class="MsoNormal"><u></u> <u></u></p></div><div><p class="MsoNormal">In the expected "public" interface, I would expand BB to BasicBlock. So, 'createPrintBasicBlockPass'.<u></u><u></u></p>
</div><div><p class="MsoNormal"><u></u> <u></u></p></div><div><p class="MsoNormal">I'm fine with the internal class name being 'PrintBBPass' or whatever is convenient to type. =]<u></u><u></u></p></div></div><div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><u></u> <u></u></p><div><p class="MsoNormal">On Fri, Feb 8, 2013 at 1:16 PM, Sergei Larin <<a href="mailto:slarin@codeaurora.org" target="_blank" class="cremed">slarin@codeaurora.org</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">Hello everyone,<br><br> I am not precisely sure who owns this code (lib/IR/Pass.cpp ...sorry...),<br>and I am not sure why to this moment we did not have<br>BasicBlockPass::createPrinterPass() defined, but I got a nasty surprise when<br>
trying to combine -mllvm -print-after-all with -mllvm -vectorize for<br>clang...<br><br> The implementation seemed straightforward, so I just decided to do it and<br>then ask for background later. So... If it is as harmless as I think it is,<br>
please review and OK the patch. If it should not be done for some reason, or<br>should be implemented differently, please let me know.<br><br>Thanks a lot.<br><br>Sergei Larin<br><br>---<br>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by<br>
The Linux Foundation<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="cremed">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</div><p class="MsoNormal"><u></u> <u></u></p></div></div></div></div></div></div></blockquote></div><br></div></div>