<p dir="ltr"><br>
On Feb 5, 2013 7:11 PM, "Eli Bendersky" <<a href="mailto:eliben@google.com">eliben@google.com</a>> wrote:<br>
><br>
> Author: eliben<br>
> Date: Tue Feb  5 21:08:02 2013<br>
> New Revision: 174483<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=174483&view=rev">http://llvm.org/viewvc/llvm-project?rev=174483&view=rev</a><br>
> Log:<br>
> Add virtual desctructor to FrameEntry to avoid error on delete-non-virtual-dtor<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/DebugInfo/DWARFDebugFrame.cpp<br>
><br>
> Modified: llvm/trunk/lib/DebugInfo/DWARFDebugFrame.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFDebugFrame.cpp?rev=174483&r1=174482&r2=174483&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFDebugFrame.cpp?rev=174483&r1=174482&r2=174483&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/lib/DebugInfo/DWARFDebugFrame.cpp (original)<br>
> +++ llvm/trunk/lib/DebugInfo/DWARFDebugFrame.cpp Tue Feb  5 21:08:02 2013<br>
> @@ -23,6 +23,9 @@ public:<br>
>    FrameEntry(FrameKind K, DataExtractor D, uint64_t Offset, uint64_t Length)<br>
>      : Kind(K), Data(D), Offset(Offset), Length(Length) {}<br>
><br>
> +  virtual ~FrameEntry() {<br>
> +  }<br>
> +<br>
>    FrameKind getKind() const { return Kind; }<br>
><br>
>    virtual void dumpHeader(raw_ostream &OS) const = 0;<br>
> @@ -54,6 +57,9 @@ public:<br>
>       DataAlignmentFactor(DataAlignmentFactor),<br>
>       ReturnAddressRegister(ReturnAddressRegister) {}<br>
><br>
> +  ~CIE() {<br>
> +  }</p>
<p dir="ltr">Why did you add these explicit destructors that are the same as the implicit ones?</p>
<p dir="ltr">> +<br>
>    void dumpHeader(raw_ostream &OS) const {<br>
>      OS << format("%08x %08x %08x CIE", Offset, Length, DW_CIE_ID) << "\n";<br>
>      OS << format("  Version:               %d\n", Version);<br>
> @@ -89,6 +95,9 @@ public:<br>
>       InitialLocation(InitialLocation), AddressRange(AddressRange),<br>
>       LinkedCIE(NULL) {}<br>
><br>
> +  ~FDE() {<br>
> +  }<br>
> +<br>
>    void dumpHeader(raw_ostream &OS) const {<br>
>      OS << format("%08x %08x %08x FDE ", Offset, Length, LinkedCIEOffset);<br>
>      OS << format("cie=%08x pc=%08x...%08x\n",<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</p>