<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div><br></div><div>On Jan 31, 2013, at 6:43 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr">On Thu, Jan 31, 2013 at 6:33 PM, Carter, Jack <span dir="ltr"><<a href="mailto:jcarter@mips.com" target="_blank" class="cremed">jcarter@mips.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>
<div style="direction:ltr;font-size:10pt;font-family:Tahoma">Jim,<br>
<br>
I'm retrofitting my Mips portion of the e_header patch to fit what was done for ARM. A few questions:<br>
<br>
Why is ARM here in MCELFStreamer.h? Is this just an early fix?<br>
<br>
<font><span style="font-size:10pt"><div class="im">> + static bool classof(const MCStreamer *S) {<br></div>
> + return S->getKind() == SK_ELFStreamer && S->getKind() == SK_ARMELFStreamer;<br>
> + }<br>
</span></font><br>
And I assume that I will want to add an SK_MipsELFStreamer enum variant to MCStreamer.h.</div></div></blockquote><div><br></div><div style="">See: <a href="http://llvm.org/docs/HowToSetUpLLVMStyleRTTI.html">http://llvm.org/docs/HowToSetUpLLVMStyleRTTI.html</a></div>
<div style=""><br></div><div style="">Actually, I think we might want to move all of the middle class checks to be based on a covered switch so we get compiler warnings to ensure everywhere gets updated.</div><div style=""><br></div>
<div style="">Thoughts Jim?</div></div></div></div>
</div></blockquote><br><div>Compile time diagnostics instead of runtime issues sounds like a win to me.</div><div><br></div><div>Jim</div></body></html>