<div dir="ltr">On Wed, Jan 30, 2013 at 2:38 PM, Michael Gottesman <span dir="ltr"><<a href="mailto:mgottesman@apple.com" target="_blank" class="cremed">mgottesman@apple.com</a>></span> wrote:<br><div class="gmail_extra">
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: mgottesman<br>
Date: Wed Jan 30 16:38:19 2013<br>
New Revision: 173983<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=173983&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=173983&view=rev</a><br>
Log:<br>
Encapsulate testing that we have an iOS Triple in Triple.h in the method isiOS<br>
so we follow the convention that all other platforms follow by having an is*<br>
test method.<br></blockquote><div><br></div><div style>Add a unit test for this as well?</div><div style><br></div><div style>(Just for pedantry's sake, clearly there is no confusing logic here. =])</div><div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    llvm/trunk/include/llvm/ADT/Triple.h<br>
<br>
Modified: llvm/trunk/include/llvm/ADT/Triple.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/Triple.h?rev=173983&r1=173982&r2=173983&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/Triple.h?rev=173983&r1=173982&r2=173983&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/include/llvm/ADT/Triple.h (original)<br>
+++ llvm/trunk/include/llvm/ADT/Triple.h Wed Jan 30 16:38:19 2013<br>
@@ -296,9 +296,14 @@ public:<br>
     return getOS() == Triple::Darwin || getOS() == Triple::MacOSX;<br>
   }<br>
<br>
+  /// Is this an iOS triple.<br>
+  bool isiOS() const {<br>
+    return getOS() == Triple::IOS;<br>
+  }<br>
+<br>
   /// isOSDarwin - Is this a "Darwin" OS (OS X or iOS).<br>
   bool isOSDarwin() const {<br>
-    return isMacOSX() || getOS() == Triple::IOS;<br>
+    return isMacOSX() || isiOS();<br>
   }<br>
<br>
   /// \brief Tests for either Cygwin or MinGW OS<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" class="cremed">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>