<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jan 30, 2013, at 11:24 AM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div class="im">
<blockquote type="cite"><div dir="ltr">Made quite a few changes between the two versions (including adding a test case, that's a good start), but didn't explain what the problems you were fixing were. What problems were you running into that needed changing?</div>
</blockquote><div><br></div></div>My bad. Since there was no response on the first patch, I assumed people will just look at the updated patch.</div><div>The updated patch makes sure we generate the same code when there is only one compile unit.</div>
<div>And the line table will be emitted in the order of CUID.</div><div><div class="im"><br></div></div></div></blockquote><div><br></div><div style="">That all makes sense. </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto;">
<div style="word-wrap:break-word"><div class="im"><blockquote type="cite"><div dir="ltr"><div>
<br></div><div>The MCLineIDs bit seems unwieldy and probably could be done a different way.</div><div><br></div></div></blockquote></div></div></blockquote><div style="">Any thoughts here? </div></div></div></div></blockquote>I used MCLineIDs for fast look-up, do you have any suggestion on what to use here?</div><div><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div><div class="im"><blockquote type="cite"><div dir="ltr"><div></div><div>The bit with CUID = -1 or CUID == 0 seems confusing, can you explain this a bit? At times -1 seems to be for invalid CUs and at other times the first/only CU?</div>
</div></blockquote></div>"-1" is the default CUID, when DwarfDebug does not exist.</div><div>So the first line table will be for CUID 0 when DwarfDebug exists, and will be for CUID -1 when DwarfDebug does not exist.</div>
<div><div class="im"><br></div></div></div></blockquote><div><br></div><div style="">This seems a bit confusing. Since, for example, we emit a CU for assembly files and so something will always be emitting a CU. I could easily not be seeing something though. At worst it really needs some comments.</div></div></div></div></blockquote>I added some comments.</div><div><div>+ // CUID and MCLineTableSymbols are set in DwarfDebug, when DwarfDebug does</div><div>+ // not exist, CUID will be -1 and MCLineTableSymbols will be empty. </div><div><br></div><div>Updated patch is attached.</div><div><br></div><div>Thanks for reviewing,</div><div>Manman</div><div></div></div></body></html>