<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Hi Renato, </div><div><br></div><div>Thanks for working on this. I have some comments. </div><div><br></div><div>The changes to ARMTargetMachine.h are unrelated to the cost model. Lets commit them in a separate patch. </div><div><br></div><div>The code in ARMTTI::getCastInstrCos looks good.</div><div><br></div><div>+ ISD, DstTy.getSimpleVT(), SrcTy.getSimpleVT());</div><div><br></div><div>Did we pass the 80-col ? I am not sure. </div><div><br></div><div>In your test cases you execute both LLC and OPT. If you are checking the LLC generates the right pattern then this test should be in tests/CodeGen/ARM/. Can you make the tests smaller ? You can write a two-line function in LL that takes the arguments and performs the operation on it. </div><div><br></div><div>Thanks,</div><div>Nadav </div><div><br></div><div><br></div><div><div>On Jan 29, 2013, at 10:32 AM, Renato Golin <<a href="mailto:renato.golin@linaro.org">renato.golin@linaro.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div style="">Hi Nadav,</div><div style=""><br></div><div style="">This is an entry level change, just to make sure everything is in the right place and the infrastructure is ready. The code change is trivial.</div><div>
<br></div><a href="http://llvm-reviews.chandlerc.com/D345">http://llvm-reviews.chandlerc.com/D345</a><br><div><br></div><div style="">I spent a bit more time on tests, to make sure the costs were correctly taken and exposing the instruction I expect to do the cast clearly stated. </div>
<div style=""><br></div><div style="">Both tests refer to the same source code, but one is vectorized and the other is not. With time, we can fill them with cost checks for other instructions, I just didn't do it because I wasn't sure they were correct (some I know aren't).</div>
<div style=""><br></div><div style="">cheers,<br></div><div style="">--renato</div></div>
<span><cast-cost.patch></span></blockquote></div><br></body></html>