<div dir="ltr">On Tue, Jan 29, 2013 at 1:49 AM, Nick Lewycky <span dir="ltr"><<a href="mailto:nlewycky@google.com" target="_blank" class="cremed">nlewycky@google.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="im">On 28 January 2013 06:22, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank" class="cremed">kcc@google.com</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
  Maybe put this into lib/Support/Valgrind.cpp and/or include/llvm/Support/Valgrind.h ?<br>
  Or maybe rename these files into something Valgrind-neutral?<br></blockquote><div><br></div></div><div>I'd prefer renaming them to something valgrind-neutral, but I simply can not think of any name. If you can think of something, go for it.</div>


<div><br></div><div>There needs to be some meaning to this name. For instance Sanitizer.h would work, as it's just as acceptable for sanitizer macros as Valgrind.h is for valgrind macros.</div></div></div></div></blockquote>
<div><br></div><div style>For sanitizer functions, shouldn't the sanitizer ship a builtin header file we include to get their declarations?</div><div style><br></div><div style>For the compatibility macros that wrap these in LLVM's code to remain interoperable, I would vote for either Compiler.h, a new Sanitizer.h, or MemoryAnnotations.h in order of vaguely decreasing preference.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div class="im"><div><br></div>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">  Nick Lewycky (who added Valgrind.*), WDYT?<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D336" target="_blank" class="cremed">http://llvm-reviews.chandlerc.com/D336</a><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="cremed">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div><br></div></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" class="cremed">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>