You can pass --enable-werror to configure to enable -Werror.<br><br><div class="gmail_quote">On Mon, Jan 28, 2013 at 12:27 PM, Reed Kotler <span dir="ltr"><<a href="mailto:rkotler@mips.com" target="_blank">rkotler@mips.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On 01/28/2013 12:12 PM, David Blaikie wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Mon, Jan 28, 2013 at 12:06 PM, Reed Kotler <<a href="mailto:rkotler@mips.com" target="_blank">rkotler@mips.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Curious as to how you are building where warnings are errors?<br>
<br>
I guess I should be doing the same before putback if the rest of the tree is<br>
clean in that way.<br>
</blockquote>
We usually keep the Clang/LLVM build warning-clean with Clang at<br>
least. Many of us use a pre-built Clang from some recent revision as<br>
the compiler we use to build our development version & we configure<br>
our builds to use -Werror to catch these sort of things as soon as<br>
possible.<br>
</blockquote></div>
I'll do the same. I just built a clean 3.2 clang/llvm from release tar files for this purpose because another time I missed a warning too. I need to make clean all my build areas so that I'm using that compiler.<div>
<div><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On 01/27/2013 09:54 PM, Craig Topper wrote:<br>
<br>
I think this left addToNoHelperNeeded as an used function.<br>
<br>
lib/Target/Mips/<u></u>MipsISelLowering.cpp:218:15: error: unused function<br>
'addToNoHelperNeeded' [-Werror,-Wunused-function]<br>
const char* addToNoHelperNeeded(const char* s) {<br>
<br>
On Sun, Jan 27, 2013 at 6:46 PM, Reed Kotler <<a href="mailto:rkotler@mips.com" target="_blank">rkotler@mips.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: rkotler<br>
Date: Sun Jan 27 20:46:49 2013<br>
New Revision: 173649<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=173649&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=173649&view=rev</a><br>
Log:<br>
Make some code a little simpler.<br>
<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/Mips/<u></u>MipsISelLowering.cpp<br>
llvm/trunk/lib/Target/Mips/<u></u>MipsISelLowering.h<br>
<br>
Modified: llvm/trunk/lib/Target/Mips/<u></u>MipsISelLowering.cpp<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp?rev=173649&r1=173648&r2=173649&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>Mips/MipsISelLowering.cpp?rev=<u></u>173649&r1=173648&r2=173649&<u></u>view=diff</a><br>
<br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/lib/Target/Mips/<u></u>MipsISelLowering.cpp (original)<br>
+++ llvm/trunk/lib/Target/Mips/<u></u>MipsISelLowering.cpp Sun Jan 27 20:46:49<br>
2013<br>
@@ -222,47 +222,45 @@ namespace {<br>
<br>
}<br>
<br>
+void MipsTargetLowering::<u></u>SetMips16LibcallName<br>
+ (RTLIB::Libcall l, const char *Name) {<br>
+ setLibcallName(l, Name);<br>
+ noHelperNeeded.insert(Name);<br>
+}<br>
+<br>
void MipsTargetLowering::<u></u>setMips16HardFloatLibCalls() {<br>
- setLibcallName(RTLIB::ADD_F32, addToNoHelperNeeded("__mips16_<u></u>addsf3"));<br>
- setLibcallName(RTLIB::ADD_F64, addToNoHelperNeeded("__mips16_<u></u>adddf3"));<br>
- setLibcallName(RTLIB::SUB_F32, addToNoHelperNeeded("__mips16_<u></u>subsf3"));<br>
- setLibcallName(RTLIB::SUB_F64, addToNoHelperNeeded("__mips16_<u></u>subdf3"));<br>
- setLibcallName(RTLIB::MUL_F32, addToNoHelperNeeded("__mips16_<u></u>mulsf3"));<br>
- setLibcallName(RTLIB::MUL_F64, addToNoHelperNeeded("__mips16_<u></u>muldf3"));<br>
- setLibcallName(RTLIB::DIV_F32, addToNoHelperNeeded("__mips16_<u></u>divsf3"));<br>
- setLibcallName(RTLIB::DIV_F64, addToNoHelperNeeded("__mips16_<u></u>divdf3"));<br>
- setLibcallName(RTLIB::FPEXT_<u></u>F32_F64,<br>
- addToNoHelperNeeded("__mips16_<u></u>extendsfdf2"));<br>
- setLibcallName(RTLIB::FPROUND_<u></u>F64_F32,<br>
- addToNoHelperNeeded("__mips16_<u></u>truncdfsf2"));<br>
- setLibcallName(RTLIB::<u></u>FPTOSINT_F32_I32,<br>
- addToNoHelperNeeded("__mips16_<u></u>fix_truncsfsi"));<br>
- setLibcallName(RTLIB::<u></u>FPTOSINT_F64_I32,<br>
- addToNoHelperNeeded("__mips16_<u></u>fix_truncdfsi"));<br>
- setLibcallName(RTLIB::<u></u>SINTTOFP_I32_F32,<br>
- addToNoHelperNeeded("__mips16_<u></u>floatsisf"));<br>
- setLibcallName(RTLIB::<u></u>SINTTOFP_I32_F64,<br>
- addToNoHelperNeeded("__mips16_<u></u>floatsidf"));<br>
- setLibcallName(RTLIB::<u></u>UINTTOFP_I32_F32,<br>
- addToNoHelperNeeded("__mips16_<u></u>floatunsisf"));<br>
- setLibcallName(RTLIB::<u></u>UINTTOFP_I32_F64,<br>
- addToNoHelperNeeded("__mips16_<u></u>floatunsidf"));<br>
- setLibcallName(RTLIB::OEQ_F32, addToNoHelperNeeded("__mips16_<u></u>eqsf2"));<br>
- setLibcallName(RTLIB::OEQ_F64, addToNoHelperNeeded("__mips16_<u></u>eqdf2"));<br>
- setLibcallName(RTLIB::UNE_F32, addToNoHelperNeeded("__mips16_<u></u>nesf2"));<br>
- setLibcallName(RTLIB::UNE_F64, addToNoHelperNeeded("__mips16_<u></u>nedf2"));<br>
- setLibcallName(RTLIB::OGE_F32, addToNoHelperNeeded("__mips16_<u></u>gesf2"));<br>
- setLibcallName(RTLIB::OGE_F64, addToNoHelperNeeded("__mips16_<u></u>gedf2"));<br>
- setLibcallName(RTLIB::OLT_F32, addToNoHelperNeeded("__mips16_<u></u>ltsf2"));<br>
- setLibcallName(RTLIB::OLT_F64, addToNoHelperNeeded("__mips16_<u></u>ltdf2"));<br>
- setLibcallName(RTLIB::OLE_F32, addToNoHelperNeeded("__mips16_<u></u>lesf2"));<br>
- setLibcallName(RTLIB::OLE_F64, addToNoHelperNeeded("__mips16_<u></u>ledf2"));<br>
- setLibcallName(RTLIB::OGT_F32, addToNoHelperNeeded("__mips16_<u></u>gtsf2"));<br>
- setLibcallName(RTLIB::OGT_F64, addToNoHelperNeeded("__mips16_<u></u>gtdf2"));<br>
- setLibcallName(RTLIB::UO_F32,<br>
addToNoHelperNeeded("__mips16_<u></u>unordsf2"));<br>
- setLibcallName(RTLIB::UO_F64,<br>
addToNoHelperNeeded("__mips16_<u></u>unorddf2"));<br>
- setLibcallName(RTLIB::O_F32, addToNoHelperNeeded("__mips16_<u></u>unordsf2"));<br>
- setLibcallName(RTLIB::O_F64, addToNoHelperNeeded("__mips16_<u></u>unorddf2"));<br>
+ SetMips16LibcallName(RTLIB::<u></u>ADD_F32, "__mips16_addsf3");<br>
+ SetMips16LibcallName(RTLIB::<u></u>ADD_F64, "__mips16_adddf3");<br>
+ SetMips16LibcallName(RTLIB::<u></u>SUB_F32, "__mips16_subsf3");<br>
+ SetMips16LibcallName(RTLIB::<u></u>SUB_F64, "__mips16_subdf3");<br>
+ SetMips16LibcallName(RTLIB::<u></u>MUL_F32, "__mips16_mulsf3");<br>
+ SetMips16LibcallName(RTLIB::<u></u>MUL_F64, "__mips16_muldf3");<br>
+ SetMips16LibcallName(RTLIB::<u></u>DIV_F32, "__mips16_divsf3");<br>
+ SetMips16LibcallName(RTLIB::<u></u>DIV_F64, "__mips16_divdf3");<br>
+ SetMips16LibcallName(RTLIB::<u></u>FPEXT_F32_F64, "__mips16_extendsfdf2");<br>
+ SetMips16LibcallName(RTLIB::<u></u>FPROUND_F64_F32, "__mips16_truncdfsf2");<br>
+ SetMips16LibcallName(RTLIB::<u></u>FPTOSINT_F32_I32,<br>
"__mips16_fix_truncsfsi");<br>
+ SetMips16LibcallName(RTLIB::<u></u>FPTOSINT_F64_I32,<br>
"__mips16_fix_truncdfsi");<br>
+ SetMips16LibcallName(RTLIB::<u></u>SINTTOFP_I32_F32, "__mips16_floatsisf");<br>
+ SetMips16LibcallName(RTLIB::<u></u>SINTTOFP_I32_F64, "__mips16_floatsidf");<br>
+ SetMips16LibcallName(RTLIB::<u></u>UINTTOFP_I32_F32, "__mips16_floatunsisf");<br>
+ SetMips16LibcallName(RTLIB::<u></u>UINTTOFP_I32_F64, "__mips16_floatunsidf");<br>
+ SetMips16LibcallName(RTLIB::<u></u>OEQ_F32, "__mips16_eqsf2");<br>
+ SetMips16LibcallName(RTLIB::<u></u>OEQ_F64, "__mips16_eqdf2");<br>
+ SetMips16LibcallName(RTLIB::<u></u>UNE_F32, "__mips16_nesf2");<br>
+ SetMips16LibcallName(RTLIB::<u></u>UNE_F64, "__mips16_nedf2");<br>
+ SetMips16LibcallName(RTLIB::<u></u>OGE_F32, "__mips16_gesf2");<br>
+ SetMips16LibcallName(RTLIB::<u></u>OGE_F64, "__mips16_gedf2");<br>
+ SetMips16LibcallName(RTLIB::<u></u>OLT_F32, "__mips16_ltsf2");<br>
+ SetMips16LibcallName(RTLIB::<u></u>OLT_F64, "__mips16_ltdf2");<br>
+ SetMips16LibcallName(RTLIB::<u></u>OLE_F32, "__mips16_lesf2");<br>
+ SetMips16LibcallName(RTLIB::<u></u>OLE_F64, "__mips16_ledf2");<br>
+ SetMips16LibcallName(RTLIB::<u></u>OGT_F32, "__mips16_gtsf2");<br>
+ SetMips16LibcallName(RTLIB::<u></u>OGT_F64, "__mips16_gtdf2");<br>
+ SetMips16LibcallName(RTLIB::<u></u>UO_F32, "__mips16_unordsf2");<br>
+ SetMips16LibcallName(RTLIB::<u></u>UO_F64, "__mips16_unorddf2");<br>
+ SetMips16LibcallName(RTLIB::O_<u></u>F32, "__mips16_unordsf2");<br>
+ SetMips16LibcallName(RTLIB::O_<u></u>F64, "__mips16_unorddf2");<br>
}<br>
<br>
MipsTargetLowering::<br>
<br>
Modified: llvm/trunk/lib/Target/Mips/<u></u>MipsISelLowering.h<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.h?rev=173649&r1=173648&r2=173649&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>Mips/MipsISelLowering.h?rev=<u></u>173649&r1=173648&r2=173649&<u></u>view=diff</a><br>
<br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/lib/Target/Mips/<u></u>MipsISelLowering.h (original)<br>
+++ llvm/trunk/lib/Target/Mips/<u></u>MipsISelLowering.h Sun Jan 27 20:46:49 2013<br>
@@ -176,6 +176,8 @@ namespace llvm {<br>
virtual SDValue PerformDAGCombine(SDNode *N, DAGCombinerInfo &DCI)<br>
const;<br>
private:<br>
<br>
+ void SetMips16LibcallName(RTLIB::<u></u>Libcall, const char *Name);<br>
+<br>
void setMips16HardFloatLibCalls();<br>
<br>
unsigned int<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</blockquote>
<br>
<br>
<br>
--<br>
~Craig<br>
<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote></blockquote>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>~Craig