<div dir="ltr">On Mon, Jan 28, 2013 at 8:20 PM, Michael Gottesman <span dir="ltr"><<a href="mailto:mgottesman@apple.com" target="_blank" class="cremed">mgottesman@apple.com</a>></span> wrote:<br><div class="gmail_extra">
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: mgottesman<br>
Date: Mon Jan 28 22:20:52 2013<br>
New Revision: 173767<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=173767&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=173767&view=rev</a><br>
Log:<br>
Sorted includes using utils/sort_includes.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/ObjCARC/DependencyAnalysis.cpp<br>
    llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAPElim.cpp<br>
    llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAliasAnalysis.cpp<br>
    llvm/trunk/lib/Transforms/ObjCARC/ObjCARCContract.cpp<br>
    llvm/trunk/lib/Transforms/ObjCARC/ObjCARCExpand.cpp<br>
    llvm/trunk/lib/Transforms/ObjCARC/ObjCARCOpts.cpp<br>
    llvm/trunk/lib/Transforms/ObjCARC/ObjCARCUtil.cpp<br>
    llvm/trunk/lib/Transforms/ObjCARC/ProvenanceAnalysis.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/ObjCARC/DependencyAnalysis.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/ObjCARC/DependencyAnalysis.cpp?rev=173767&r1=173766&r2=173767&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/ObjCARC/DependencyAnalysis.cpp?rev=173767&r1=173766&r2=173767&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Transforms/ObjCARC/DependencyAnalysis.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/ObjCARC/DependencyAnalysis.cpp Mon Jan 28 22:20:52 2013<br>
@@ -22,9 +22,8 @@<br>
<br>
 #define DEBUG_TYPE "objc-arc-dependency"<br>
 #include "ObjCARC.h"<br>
-#include "ProvenanceAnalysis.h"<br>
 #include "DependencyAnalysis.h"<br>
-<br>
+#include "ProvenanceAnalysis.h"<br>
 #include "llvm/Support/CFG.h"<br></blockquote><div><br></div><div style>Just FYI, the script assumes that for FooBar.cpp, the first #include is the header which declares the interface defined by that source file.</div>
<div style><br></div><div style>So for this file, it would expect DependencyAnalysis.h to be the first include, and for something like SROA.cpp, it expects Scalar.h (which declares the one external function defined there) to be the first include.</div>
<div style><br></div><div style>You'll have to fix this manually, because based on this assumption, it ends up sorting all but the first header.</div><div style>-Chandler</div></div></div></div>