<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Can you please send the patch to the mailing list ?<div><br></div><div>Thanks,</div><div>Nadav</div><div><br><div><div>On Jan 28, 2013, at 4:04 AM, Renato Golin <<a href="mailto:renato.golin@linaro.org">renato.golin@linaro.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><a href="http://llvm-reviews.chandlerc.com/D335">http://llvm-reviews.chandlerc.com/D335</a><br><div><br></div><div style="">Small patch to (hopefully) clarify what the parameters mean (width/cost) from the std::pair<>'s first/second approach.</div>
<div style=""><br></div><div style="">There's also a potentially problematic (and wrong) change by the end. I'm assuming the cost we want to return is the cost of the cheapest width multiplied by the width where that cost was calculated, not by the maximum width.</div>
<div style=""><br></div><div style="">It's possible that this was never a problem, if on all tests, the maximum width is the one always returned (in which case, Width == VF).</div><div style=""><br></div><div style="">cheers,</div>
<div style="">--renato</div></div>
</blockquote></div><br></div></body></html>