<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 01/27/2013 09:54 PM, Craig Topper
wrote:<br>
</div>
<blockquote
cite="mid:CAF7ks-PdTj5i1K_QXNw8eQzy5LTU0AYrr6OQsDWRjx=3txawKA@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
I think this left addToNoHelperNeeded as an used function.<br>
<br>
</blockquote>
You're right.<br>
<br>
Thanks. I saw that you removed the routine in a later patch.<br>
<br>
<blockquote
cite="mid:CAF7ks-PdTj5i1K_QXNw8eQzy5LTU0AYrr6OQsDWRjx=3txawKA@mail.gmail.com"
type="cite">lib/Target/Mips/MipsISelLowering.cpp:218:15: error:
unused function 'addToNoHelperNeeded' [-Werror,-Wunused-function]<br>
const char* addToNoHelperNeeded(const char* s) {<br>
<br>
<div class="gmail_quote">On Sun, Jan 27, 2013 at 6:46 PM, Reed
Kotler <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:rkotler@mips.com" target="_blank">rkotler@mips.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: rkotler<br>
Date: Sun Jan 27 20:46:49 2013<br>
New Revision: 173649<br>
<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project?rev=173649&view=rev"
target="_blank">http://llvm.org/viewvc/llvm-project?rev=173649&view=rev</a><br>
Log:<br>
Make some code a little simpler.<br>
<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp<br>
llvm/trunk/lib/Target/Mips/MipsISelLowering.h<br>
<br>
Modified: llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp?rev=173649&r1=173648&r2=173649&view=diff"
target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp?rev=173649&r1=173648&r2=173649&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp (original)<br>
+++ llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp Sun Jan 27
20:46:49 2013<br>
@@ -222,47 +222,45 @@ namespace {<br>
<br>
}<br>
<br>
+void MipsTargetLowering::SetMips16LibcallName<br>
+ (RTLIB::Libcall l, const char *Name) {<br>
+ setLibcallName(l, Name);<br>
+ noHelperNeeded.insert(Name);<br>
+}<br>
+<br>
void MipsTargetLowering::setMips16HardFloatLibCalls() {<br>
- setLibcallName(RTLIB::ADD_F32,
addToNoHelperNeeded("__mips16_addsf3"));<br>
- setLibcallName(RTLIB::ADD_F64,
addToNoHelperNeeded("__mips16_adddf3"));<br>
- setLibcallName(RTLIB::SUB_F32,
addToNoHelperNeeded("__mips16_subsf3"));<br>
- setLibcallName(RTLIB::SUB_F64,
addToNoHelperNeeded("__mips16_subdf3"));<br>
- setLibcallName(RTLIB::MUL_F32,
addToNoHelperNeeded("__mips16_mulsf3"));<br>
- setLibcallName(RTLIB::MUL_F64,
addToNoHelperNeeded("__mips16_muldf3"));<br>
- setLibcallName(RTLIB::DIV_F32,
addToNoHelperNeeded("__mips16_divsf3"));<br>
- setLibcallName(RTLIB::DIV_F64,
addToNoHelperNeeded("__mips16_divdf3"));<br>
- setLibcallName(RTLIB::FPEXT_F32_F64,<br>
-
addToNoHelperNeeded("__mips16_extendsfdf2"));<br>
- setLibcallName(RTLIB::FPROUND_F64_F32,<br>
- addToNoHelperNeeded("__mips16_truncdfsf2"));<br>
- setLibcallName(RTLIB::FPTOSINT_F32_I32,<br>
-
addToNoHelperNeeded("__mips16_fix_truncsfsi"));<br>
- setLibcallName(RTLIB::FPTOSINT_F64_I32,<br>
-
addToNoHelperNeeded("__mips16_fix_truncdfsi"));<br>
- setLibcallName(RTLIB::SINTTOFP_I32_F32,<br>
- addToNoHelperNeeded("__mips16_floatsisf"));<br>
- setLibcallName(RTLIB::SINTTOFP_I32_F64,<br>
- addToNoHelperNeeded("__mips16_floatsidf"));<br>
- setLibcallName(RTLIB::UINTTOFP_I32_F32,<br>
-
addToNoHelperNeeded("__mips16_floatunsisf"));<br>
- setLibcallName(RTLIB::UINTTOFP_I32_F64,<br>
-
addToNoHelperNeeded("__mips16_floatunsidf"));<br>
- setLibcallName(RTLIB::OEQ_F32,
addToNoHelperNeeded("__mips16_eqsf2"));<br>
- setLibcallName(RTLIB::OEQ_F64,
addToNoHelperNeeded("__mips16_eqdf2"));<br>
- setLibcallName(RTLIB::UNE_F32,
addToNoHelperNeeded("__mips16_nesf2"));<br>
- setLibcallName(RTLIB::UNE_F64,
addToNoHelperNeeded("__mips16_nedf2"));<br>
- setLibcallName(RTLIB::OGE_F32,
addToNoHelperNeeded("__mips16_gesf2"));<br>
- setLibcallName(RTLIB::OGE_F64,
addToNoHelperNeeded("__mips16_gedf2"));<br>
- setLibcallName(RTLIB::OLT_F32,
addToNoHelperNeeded("__mips16_ltsf2"));<br>
- setLibcallName(RTLIB::OLT_F64,
addToNoHelperNeeded("__mips16_ltdf2"));<br>
- setLibcallName(RTLIB::OLE_F32,
addToNoHelperNeeded("__mips16_lesf2"));<br>
- setLibcallName(RTLIB::OLE_F64,
addToNoHelperNeeded("__mips16_ledf2"));<br>
- setLibcallName(RTLIB::OGT_F32,
addToNoHelperNeeded("__mips16_gtsf2"));<br>
- setLibcallName(RTLIB::OGT_F64,
addToNoHelperNeeded("__mips16_gtdf2"));<br>
- setLibcallName(RTLIB::UO_F32,
addToNoHelperNeeded("__mips16_unordsf2"));<br>
- setLibcallName(RTLIB::UO_F64,
addToNoHelperNeeded("__mips16_unorddf2"));<br>
- setLibcallName(RTLIB::O_F32,
addToNoHelperNeeded("__mips16_unordsf2"));<br>
- setLibcallName(RTLIB::O_F64,
addToNoHelperNeeded("__mips16_unorddf2"));<br>
+ SetMips16LibcallName(RTLIB::ADD_F32, "__mips16_addsf3");<br>
+ SetMips16LibcallName(RTLIB::ADD_F64, "__mips16_adddf3");<br>
+ SetMips16LibcallName(RTLIB::SUB_F32, "__mips16_subsf3");<br>
+ SetMips16LibcallName(RTLIB::SUB_F64, "__mips16_subdf3");<br>
+ SetMips16LibcallName(RTLIB::MUL_F32, "__mips16_mulsf3");<br>
+ SetMips16LibcallName(RTLIB::MUL_F64, "__mips16_muldf3");<br>
+ SetMips16LibcallName(RTLIB::DIV_F32, "__mips16_divsf3");<br>
+ SetMips16LibcallName(RTLIB::DIV_F64, "__mips16_divdf3");<br>
+ SetMips16LibcallName(RTLIB::FPEXT_F32_F64,
"__mips16_extendsfdf2");<br>
+ SetMips16LibcallName(RTLIB::FPROUND_F64_F32,
"__mips16_truncdfsf2");<br>
+ SetMips16LibcallName(RTLIB::FPTOSINT_F32_I32,
"__mips16_fix_truncsfsi");<br>
+ SetMips16LibcallName(RTLIB::FPTOSINT_F64_I32,
"__mips16_fix_truncdfsi");<br>
+ SetMips16LibcallName(RTLIB::SINTTOFP_I32_F32,
"__mips16_floatsisf");<br>
+ SetMips16LibcallName(RTLIB::SINTTOFP_I32_F64,
"__mips16_floatsidf");<br>
+ SetMips16LibcallName(RTLIB::UINTTOFP_I32_F32,
"__mips16_floatunsisf");<br>
+ SetMips16LibcallName(RTLIB::UINTTOFP_I32_F64,
"__mips16_floatunsidf");<br>
+ SetMips16LibcallName(RTLIB::OEQ_F32, "__mips16_eqsf2");<br>
+ SetMips16LibcallName(RTLIB::OEQ_F64, "__mips16_eqdf2");<br>
+ SetMips16LibcallName(RTLIB::UNE_F32, "__mips16_nesf2");<br>
+ SetMips16LibcallName(RTLIB::UNE_F64, "__mips16_nedf2");<br>
+ SetMips16LibcallName(RTLIB::OGE_F32, "__mips16_gesf2");<br>
+ SetMips16LibcallName(RTLIB::OGE_F64, "__mips16_gedf2");<br>
+ SetMips16LibcallName(RTLIB::OLT_F32, "__mips16_ltsf2");<br>
+ SetMips16LibcallName(RTLIB::OLT_F64, "__mips16_ltdf2");<br>
+ SetMips16LibcallName(RTLIB::OLE_F32, "__mips16_lesf2");<br>
+ SetMips16LibcallName(RTLIB::OLE_F64, "__mips16_ledf2");<br>
+ SetMips16LibcallName(RTLIB::OGT_F32, "__mips16_gtsf2");<br>
+ SetMips16LibcallName(RTLIB::OGT_F64, "__mips16_gtdf2");<br>
+ SetMips16LibcallName(RTLIB::UO_F32, "__mips16_unordsf2");<br>
+ SetMips16LibcallName(RTLIB::UO_F64, "__mips16_unorddf2");<br>
+ SetMips16LibcallName(RTLIB::O_F32, "__mips16_unordsf2");<br>
+ SetMips16LibcallName(RTLIB::O_F64, "__mips16_unorddf2");<br>
}<br>
<br>
MipsTargetLowering::<br>
<br>
Modified: llvm/trunk/lib/Target/Mips/MipsISelLowering.h<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.h?rev=173649&r1=173648&r2=173649&view=diff"
target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.h?rev=173649&r1=173648&r2=173649&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/Mips/MipsISelLowering.h (original)<br>
+++ llvm/trunk/lib/Target/Mips/MipsISelLowering.h Sun Jan 27
20:46:49 2013<br>
@@ -176,6 +176,8 @@ namespace llvm {<br>
virtual SDValue PerformDAGCombine(SDNode *N,
DAGCombinerInfo &DCI) const;<br>
private:<br>
<br>
+ void SetMips16LibcallName(RTLIB::Libcall, const char
*Name);<br>
+<br>
void setMips16HardFloatLibCalls();<br>
<br>
unsigned int<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
~Craig
</blockquote>
<br>
</body>
</html>