Oops. That should have said "128-bit lanes."<br><br><div class="gmail_quote">On Sun, Jan 27, 2013 at 11:41 PM, Craig Topper <span dir="ltr"><<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ctopper<br>
Date: Mon Jan 28 01:41:18 2013<br>
New Revision: 173674<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=173674&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=173674&view=rev</a><br>
Log:<br>
Fix 256-bit PALIGNR comment decoding to understand that it works on independent 256-bit lanes.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/X86/Utils/X86ShuffleDecode.cpp<br>
    llvm/trunk/test/MC/X86/shuffle-comments.s<br>
<br>
Modified: llvm/trunk/lib/Target/X86/Utils/X86ShuffleDecode.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/Utils/X86ShuffleDecode.cpp?rev=173674&r1=173673&r2=173674&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/Utils/X86ShuffleDecode.cpp?rev=173674&r1=173673&r2=173674&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Target/X86/Utils/X86ShuffleDecode.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/Utils/X86ShuffleDecode.cpp Mon Jan 28 01:41:18 2013<br>
@@ -66,8 +66,17 @@ void DecodePALIGNRMask(MVT VT, unsigned<br>
   unsigned NumElts = VT.getVectorNumElements();<br>
   unsigned Offset = Imm * (VT.getVectorElementType().getSizeInBits() / 8);<br>
<br>
-  for (unsigned i = 0; i != NumElts; ++i)<br>
-    ShuffleMask.push_back((i + Offset) % (NumElts * 2));<br>
+  unsigned NumLanes = VT.getSizeInBits() / 128;<br>
+  unsigned NumLaneElts = NumElts / NumLanes;<br>
+<br>
+  for (unsigned l = 0; l != NumElts; l += NumLaneElts) {<br>
+    for (unsigned i = 0; i != NumLaneElts; ++i) {<br>
+      unsigned Base = i + Offset;<br>
+      // if i+offset is out of this lane then we actually need the other source<br>
+      if (Base >= NumLaneElts) Base += NumElts - NumLaneElts;<br>
+      ShuffleMask.push_back(Base + l);<br>
+    }<br>
+  }<br>
 }<br>
<br>
 /// DecodePSHUFMask - This decodes the shuffle masks for pshufd, and vpermilp*.<br>
<br>
Modified: llvm/trunk/test/MC/X86/shuffle-comments.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/X86/shuffle-comments.s?rev=173674&r1=173673&r2=173674&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/X86/shuffle-comments.s?rev=173674&r1=173673&r2=173674&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/test/MC/X86/shuffle-comments.s (original)<br>
+++ llvm/trunk/test/MC/X86/shuffle-comments.s Mon Jan 28 01:41:18 2013<br>
@@ -29,3 +29,18 @@ vpalignr $0, %xmm0, %xmm1, %xmm2<br>
 # CHECK: xmm2 = xmm0[0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15]<br>
 vpalignr $0, (%rax), %xmm1, %xmm2<br>
 # CHECK: xmm2 = mem[0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15]<br>
+<br>
+vpalignr $8, %ymm0, %ymm1, %ymm2<br>
+# CHECK: ymm2 = ymm0[8,9,10,11,12,13,14,15],ymm1[0,1,2,3,4,5,6,7],ymm0[24,25,26,27,28,29,30,31],ymm1[16,17,18,19,20,21,22,23]<br>
+vpalignr $8, (%rax), %ymm1, %ymm2<br>
+# CHECK: ymm2 = mem[8,9,10,11,12,13,14,15],ymm1[0,1,2,3,4,5,6,7],mem[24,25,26,27,28,29,30,31],ymm1[16,17,18,19,20,21,22,23]<br>
+<br>
+vpalignr $16, %ymm0, %ymm1, %ymm2<br>
+# CHECK: ymm2 = ymm1[0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31]<br>
+vpalignr $16, (%rax), %ymm1, %ymm2<br>
+# CHECK: ymm2 = ymm1[0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31]<br>
+<br>
+vpalignr $0, %ymm0, %ymm1, %ymm2<br>
+# CHECK: ymm2 = ymm0[0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31]<br>
+vpalignr $0, (%rax), %ymm1, %ymm2<br>
+# CHECK: ymm2 = mem[0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31]<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><br>-- <br>~Craig