<p dir="ltr">I believe the correct (stylistically) change here is to change the 'if' to 'assert', rather than adding else-unreachable</p>
<div class="gmail_quote">On Jan 23, 2013 10:11 PM, "NAKAMURA Takumi" <<a href="mailto:geek4civic@gmail.com">geek4civic@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: chapuni<br>
Date: Thu Jan 24 00:08:06 2013<br>
New Revision: 173325<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=173325&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=173325&view=rev</a><br>
Log:<br>
MipsISelLowering.cpp: Fill unreachable paths to fix warnings. [-Wsometimes-uninitialized]<br>
<br>
FIXME: Could they, unreachable(s), be removed?<br>
FIXME: I could prefer the coding standards...<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp?rev=173325&r1=173324&r2=173325&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp?rev=173325&r1=173324&r2=173325&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp (original)<br>
+++ llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp Thu Jan 24 00:08:06 2013<br>
@@ -2917,6 +2917,12 @@<br>
                (RetTy->getContainedType(1)->isDoubleTy())) {<br>
         result = dcMips16Helper[stubNum];<br>
       }<br>
+      else {<br>
+        llvm_unreachable("Uncovered condition");<br>
+      }<br>
+    }<br>
+    else {<br>
+      llvm_unreachable("Uncovered condition");<br>
     }<br>
   }<br>
   else {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>