<div dir="ltr"><div class="gmail_default" style>Good point, applied the same change to configure+make in r173016.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 21, 2013 at 12:33 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Does this mean that the run-time library built with configure+make will be different from the one built w/ cmake? </div>
<div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 21, 2013 at 12:24 PM, Alexey Samsonov <span dir="ltr"><<a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: samsonov<br>
Date: Mon Jan 21 02:24:19 2013<br>
New Revision: 173013<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=173013&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=173013&view=rev</a><br>
Log:<br>
ASan: build runtime library with ASAN_FLEXIBLE_MAPPING_AND_OFFSET=1 as shadow mapping/offset are always emitted by the LLVM backend now<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/asan/CMakeLists.txt<br>
<br>
Modified: compiler-rt/trunk/lib/asan/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/CMakeLists.txt?rev=173013&r1=173012&r2=173013&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/CMakeLists.txt?rev=173013&r1=173012&r2=173013&view=diff</a><br>


==============================================================================<br>
--- compiler-rt/trunk/lib/asan/CMakeLists.txt (original)<br>
+++ compiler-rt/trunk/lib/asan/CMakeLists.txt Mon Jan 21 02:24:19 2013<br>
@@ -32,25 +32,22 @@<br>
<br>
 set(ASAN_CFLAGS ${SANITIZER_COMMON_CFLAGS})<br>
<br>
+set(ASAN_COMMON_DEFINITIONS<br>
+  ASAN_HAS_EXCEPTIONS=1<br>
+  ASAN_FLEXIBLE_MAPPING_AND_OFFSET=1)<br>
+<br>
 if(ANDROID)<br>
-  set(ASAN_COMMON_DEFINITIONS<br>
-    ASAN_HAS_EXCEPTIONS=1<br>
-    ASAN_FLEXIBLE_MAPPING_AND_OFFSET=0<br>
+  list(APPEND ASAN_COMMON_DEFINITIONS<br>
     ASAN_NEEDS_SEGV=0<br>
-    ASAN_LOW_MEMORY=1<br>
-    )<br>
+    ASAN_LOW_MEMORY=1)<br>
 else()<br>
-  set(ASAN_COMMON_DEFINITIONS<br>
-    ASAN_HAS_EXCEPTIONS=1<br>
-    ASAN_FLEXIBLE_MAPPING_AND_OFFSET=0<br>
-    ASAN_NEEDS_SEGV=1<br>
-    )<br>
+  list(APPEND ASAN_COMMON_DEFINITIONS<br>
+    ASAN_NEEDS_SEGV=1)<br>
 endif()<br>
<br>
 set(ASAN_DYLIB_DEFINITIONS<br>
   ${ASAN_COMMON_DEFINITIONS}<br>
-  MAC_INTERPOSE_FUNCTIONS=1<br>
-  )<br>
+  MAC_INTERPOSE_FUNCTIONS=1)<br>
<br>
 # Architectures supported by ASan.<br>
 filter_available_targets(ASAN_SUPPORTED_ARCH<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</div>