<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Please watch out for 80-col violations.<div>+CostTable::CostTable(const CostTableEntry *table, const size_t size, unsigned numTypes)</div><div><br></div><div>Another stylistic nitpick:</div><div><br></div><div><div>+unsigned CostTable::_findCost(int ISD, MVT *Types) const {</div><div>+ for (unsigned i = 0; i < size; ++i) {</div><div>+ if (table[i].ISD == ISD) {</div></div><div><br></div><div>This is almost always better because it reduces indentation.</div><div><div>+unsigned CostTable::_findCost(int ISD, MVT *Types) const {</div><div>+ for (unsigned i = 0; i < size; ++i) {</div><div>+ if (table[i].ISD != ISD)</div></div><div> continue;</div><div><br></div><div>But my real question is whether the table should be sorted so the look up can be faster?</div><div><br></div><div><div>Evan</div><div><br><div><div>On Jan 16, 2013, at 1:30 PM, Renato Golin Linaro <<a href="mailto:renato.golin@linaro.org">renato.golin@linaro.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div><div class="gmail_extra">On 16 January 2013 21:13, Nadav Rotem <span dir="ltr"><<a href="mailto:nrotem@apple.com" target="_blank">nrotem@apple.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div style="word-wrap:break-word">LGTM!</div></blockquote><div><br></div><div>Thanks!<div><br></div><div>committed in r172658.<br></div></div><div><br></div><div style="">cheers,</div><div style="">--renato</div></div></div></div>
</div>
_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></div></body></html>