<div dir="ltr"><div class="gmail_default" style><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 14, 2013 at 6:06 PM, Evgeniy Stepanov <span dir="ltr"><<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: eugenis<br>
Date: Mon Jan 14 08:06:58 2013<br>
New Revision: 172408<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=172408&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=172408&view=rev</a><br>
Log:<br>
Remove thread-locals from sanitizer_common tests.<br>
<br>
Not supported on Android.<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_allocator64_testlib.cc<br>
    compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_allocator_test.cc<br>
    compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_list_test.cc<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_allocator64_testlib.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_allocator64_testlib.cc?rev=172408&r1=172407&r2=172408&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_allocator64_testlib.cc?rev=172408&r1=172407&r2=172408&view=diff</a><br>

==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_allocator64_testlib.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_allocator64_testlib.cc Mon Jan 14 08:06:58 2013<br>
@@ -34,7 +34,7 @@<br>
 typedef CombinedAllocator<PrimaryAllocator, AllocatorCache,<br>
           SecondaryAllocator> Allocator;<br>
<br>
-static THREADLOCAL AllocatorCache cache;<br>
+static AllocatorCache cache;<br>
 static Allocator allocator;<br>
<br>
 static int inited = 0;<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_allocator_test.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_allocator_test.cc?rev=172408&r1=172407&r2=172408&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_allocator_test.cc?rev=172408&r1=172407&r2=172408&view=diff</a><br>

==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_allocator_test.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_allocator_test.cc Mon Jan 14 08:06:58 2013<br>
@@ -386,7 +386,7 @@<br>
<br>
 template <class AllocatorCache><br>
 void TestSizeClassAllocatorLocalCache() {<br>
-  static THREADLOCAL AllocatorCache static_allocator_cache;<br>
+  static AllocatorCache static_allocator_cache;<br>
   static_allocator_cache.Init();<br>
   AllocatorCache cache;<br>
   typedef typename AllocatorCache::Allocator Allocator;<br>
@@ -438,7 +438,7 @@<br>
<br>
 #if SANITIZER_WORDSIZE == 64<br>
 typedef SizeClassAllocatorLocalCache<Allocator64> AllocatorCache;<br>
-static THREADLOCAL AllocatorCache static_allocator_cache;<br>
+static AllocatorCache static_allocator_cache;<br>
<br>
 void *AllocatorLeakTestWorker(void *arg) {<br>
   typedef AllocatorCache::Allocator Allocator;<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_list_test.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_list_test.cc?rev=172408&r1=172407&r2=172408&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_list_test.cc?rev=172408&r1=172407&r2=172408&view=diff</a><br>

==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_list_test.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_list_test.cc Mon Jan 14 08:06:58 2013<br>
@@ -21,8 +21,7 @@<br>
<br>
 typedef IntrusiveList<ListItem> List;<br>
<br>
-// Check that IntrusiveList can be made thread-local.<br>
-static THREADLOCAL List static_list;<br>
+static List static_list;<br></blockquote><div><br></div><div style>Do you think it's worth putting this under #ifdef? I think I've seen some reasonable errors that were</div><div style>__thread-specific.<br></div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
 static void SetList(List *l, ListItem *x = 0,<br>
                     ListItem *y = 0, ListItem *z = 0) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</div></div>