<div dir="ltr">Oops, thanks for the heads up, Michael. I had `#ifdef LLVM_HAS_RVALUE_REFERENCES` when I meant `#if`. Committed a fix in r172454.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 14, 2013 at 11:33 AM, Michael Gottesman <span dir="ltr"><<a href="mailto:mgottesman@apple.com" target="_blank">mgottesman@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">And a darwin-10 bot as well:<br>
<br>
<a href="http://lab.llvm.org:8011/builders/clang-x86_64-darwin10-nt-O3/builds/3462/steps/compile/logs/stdio" target="_blank">http://lab.llvm.org:8011/builders/clang-x86_64-darwin10-nt-O3/builds/3462/steps/compile/logs/stdio</a><br>

<br>
\Done.<br>
<div class="HOEnZb"><div class="h5"><br>
On Jan 14, 2013, at 11:32 AM, Michael Gottesman <<a href="mailto:mgottesman@apple.com">mgottesman@apple.com</a>> wrote:<br>
<br>
> Looks like this commit broke the llvm-x86_64-ubuntu build.<br>
><br>
> <a href="http://lab.llvm.org:8011/builders/llvm-x86_64-ubuntu/builds/6922/steps/compile/logs/stdio" target="_blank">http://lab.llvm.org:8011/builders/llvm-x86_64-ubuntu/builds/6922/steps/compile/logs/stdio</a><br>
><br>
> Michael<br>
><br>
> On Jan 14, 2013, at 11:24 AM, Joe Groff <<a href="mailto:arcata@gmail.com">arcata@gmail.com</a>> wrote:<br>
><br>
>> Author: joe<br>
>> Date: Mon Jan 14 13:24:15 2013<br>
>> New Revision: 172453<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=172453&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=172453&view=rev</a><br>
>> Log:<br>
>> Add DenseMap::insert(value_type&&) method.<br>
>> Use the existing move implementation of the internal DenseMap::InsertIntoBucket<br>
>> method to provide a user-facing move insert method.<br>
>><br>
>> Modified:<br>
>>   llvm/trunk/include/llvm/ADT/DenseMap.h<br>
>><br>
>> Modified: llvm/trunk/include/llvm/ADT/DenseMap.h<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/DenseMap.h?rev=172453&r1=172452&r2=172453&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/DenseMap.h?rev=172453&r1=172452&r2=172453&view=diff</a><br>

>> ==============================================================================<br>
>> --- llvm/trunk/include/llvm/ADT/DenseMap.h (original)<br>
>> +++ llvm/trunk/include/llvm/ADT/DenseMap.h Mon Jan 14 13:24:15 2013<br>
>> @@ -159,6 +159,24 @@<br>
>>    return std::make_pair(iterator(TheBucket, getBucketsEnd(), true), true);<br>
>>  }<br>
>><br>
>> +#ifdef LLVM_HAS_RVALUE_REFERENCES<br>
>> +  // Inserts key,value pair into the map if the key isn't already in the map.<br>
>> +  // If the key is already in the map, it returns false and doesn't update the<br>
>> +  // value.<br>
>> +  std::pair<iterator, bool> insert(std::pair<KeyT, ValueT> &&KV) {<br>
>> +    BucketT *TheBucket;<br>
>> +    if (LookupBucketFor(KV.first, TheBucket))<br>
>> +      return std::make_pair(iterator(TheBucket, getBucketsEnd(), true),<br>
>> +                            false); // Already in map.<br>
>> +<br>
>> +    // Otherwise, insert the new element.<br>
>> +    TheBucket = InsertIntoBucket(std::move(KV.first),<br>
>> +                                 std::move(KV.second),<br>
>> +                                 TheBucket);<br>
>> +    return std::make_pair(iterator(TheBucket, getBucketsEnd(), true), true);<br>
>> +  }<br>
>> +#endif<br>
>> +<br>
>>  /// insert - Range insertion of pairs.<br>
>>  template<typename InputIt><br>
>>  void insert(InputIt I, InputIt E) {<br>
>><br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
<br>
</div></div></blockquote></div><br></div>