<div dir="ltr"><div class="gmail_default" style><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jan 10, 2013 at 9:56 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Thu, Jan 10, 2013 at 5:33 AM, Kostya Serebryany <<a href="mailto:kcc@google.com">kcc@google.com</a>> wrote:<br>

> Author: kcc<br>
> Date: Thu Jan 10 07:33:15 2013<br>
> New Revision: 172068<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=172068&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=172068&view=rev</a><br>
> Log:<br>
> [sanitizer] fix the non-cmake build (2-nd attempt)<br>
><br>
> Modified:<br>
>     compiler-rt/trunk/lib/sanitizer_common/tests/standalone_malloc_test.cc<br>
><br>
> Modified: compiler-rt/trunk/lib/sanitizer_common/tests/standalone_malloc_test.cc<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/tests/standalone_malloc_test.cc?rev=172068&r1=172067&r2=172068&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/tests/standalone_malloc_test.cc?rev=172068&r1=172067&r2=172068&view=diff</a><br>

> ==============================================================================<br>
> --- compiler-rt/trunk/lib/sanitizer_common/tests/standalone_malloc_test.cc (original)<br>
> +++ compiler-rt/trunk/lib/sanitizer_common/tests/standalone_malloc_test.cc Thu Jan 10 07:33:15 2013<br>
> @@ -56,4 +56,5 @@<br>
>    for (size_t i = 0; i < kNumThreds; i++)<br>
>      pthread_join(t[i], 0);<br>
>    malloc_stats();<br>
> +  return 0;<br>
<br>
</div>What differences between the cmake and configure+make (I assume that's<br>
the "non-cmake build" you're referring to) exist that lead you to need<br>
to make this change? That seems like an inconsistency that<br>
could/should be fixed.<br></blockquote><div><br></div><div style>cmake has a list of files to compile and then link into a test. </div><div style>configure+make uses a wild card. This file matches the wild card but I did not intend to link it together with other tests. </div>
<div style><br></div><div style>--kcc </div><div style><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
>  }<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>