<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi, Eric:<br>
<br>
Thank you for your feedback. See following inline comment. <br>
<br>
On 1/8/13 4:28 PM, Eric Christopher wrote:<br>
</div>
<blockquote
cite="mid:CALehDX7pfSC4R-Aw7+ucjCs7gBje5CYFY7f2SJjJEJqtCxBpxA@mail.gmail.com"
type="cite">
<div dir="ltr">Making no claims about this:<br>
<div class="gmail_extra"><br>
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Consider expression "0.0 - X" as the negation of X if<br>
- this expression is explicitly marked no-signed-zero,
or<br>
- no-signed-zero of this expression can be derived from
some context.<br>
<br>
</blockquote>
<div><br>
</div>
<div style="">since I haven't reviewed that part. However,</div>
</div>
</div>
</div>
</blockquote>
I sent the review request to the list last week. There are few
discussion about this change. <br>
I guess I'm ok to commit now. <br>
<br>
<blockquote
cite="mid:CALehDX7pfSC4R-Aw7+ucjCs7gBje5CYFY7f2SJjJEJqtCxBpxA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div style=""> <br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
+ /// Return true if the value is negative zero or null
value.<br>
+ bool isZeroValue() const;<br>
+<br>
</blockquote>
<div><br>
</div>
<div style="">The naming of this routine is really odd given
the function just above it in the file and</div>
</div>
</div>
</div>
</blockquote>
<br>
class Constant has a member function call isNegativeZeroValue(). <br>
I don't feel like to invent a completely different name, so I coin
the name "isZeroValue()". <br>
When the isZeroValue() and isNegativeZeroValue() stands
side-by-side, it ease the reader <br>
to guess that isZeroValue() tries to achieve. <br>
<br>
What's your suggestion?<br>
<blockquote
cite="mid:CALehDX7pfSC4R-Aw7+ucjCs7gBje5CYFY7f2SJjJEJqtCxBpxA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
+bool Constant::isZeroValue() const {<br>
+ // Floating point values have an explicit -0.0 value.<br>
+ if (const ConstantFP *CFP =
dyn_cast<ConstantFP>(this))<br>
+ return CFP->isZero();<br>
+<br>
+ // Otherwise, just use +0.0.<br>
+ return isNullValue();<br>
+}<br>
+<br>
</blockquote>
<div><br>
</div>
<div style="">and the implementation. Can you explain a bit
more?</div>
<br>
</div>
</div>
</div>
</blockquote>
This function will return true iff :<br>
- is integer 0, or <br>
- is floating point positive or negative 0, i.e. we don't care
sign.<br>
<br>
Thanks<br>
Shuxin<br>
<br>
<br>
<br>
<br>
</body>
</html>