<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi, Eric:<br>
<br>
Thank you for your feedback. See the question/comment inline.<br>
<br>
On 1/7/13 2:01 PM, Eric Christopher wrote:<br>
</div>
<blockquote
cite="mid:CALehDX7L24kbmMbZb-mXKEMXucTEF-LmFzgwan6fTnM4P+_qeg@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
+ Value *foldFMulConst(Instruction *FMulOrDiv, ConstantFP
*C,<br>
+ Instruction *InsertBefore);<br>
</blockquote>
<div><br>
</div>
<div style="">Formatting.</div>
</div>
</div>
</div>
</blockquote>
<br>
The real code in VI/emacs and the diff sent to the list looks quite
different from what you pasted here. <br>
In the code the two "Instruction"s are aligned. (I'm sure there is
no leading tab, I configure my vi such <br>
that all tab is converted to space). <br>
<br>
Are you talking about the alignment issue. Or something else? <br>
I cannot fold the 2nd line to the previous line as it exceeds 80
column. <br>
<br>
<blockquote
cite="mid:CALehDX7L24kbmMbZb-mXKEMXucTEF-LmFzgwan6fTnM4P+_qeg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
+ if (!I || (I->getOpcode() != Instruction::FMul
&&<br>
+ I->getOpcode() != Instruction::FDiv)) {<br>
+ return false;<br>
+ }<br>
+<br>
</blockquote>
<div><br>
</div>
<div style="">No need for braces here.</div>
</div>
</div>
</div>
</blockquote>
Okay. <br>
<blockquote
cite="mid:CALehDX7L24kbmMbZb-mXKEMXucTEF-LmFzgwan6fTnM4P+_qeg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
+Value *InstCombiner::foldFMulConst<br>
+ (Instruction *FMulOrDiv, ConstantFP *C, Instruction
*InsertBefore) {<br>
</blockquote>
<div><br>
</div>
<div style="">Formatting.</div>
</div>
</div>
</div>
</blockquote>
The 2nd line is indented by 2 space in the real-code? <br>
By "formating", do you mean format like this:<br>
"Value *class::member (type para1, /*80-th-column here*/<br>
type para2);<br>
<br>
<br>
<br>
<blockquote
cite="mid:CALehDX7L24kbmMbZb-mXKEMXucTEF-LmFzgwan6fTnM4P+_qeg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
+ if (C0) {<br>
+ std::swap(C0, C1); std::swap(Opnd0, Opnd1);
Swap = true;<br>
+ }<br>
+<br>
</blockquote>
<div><br>
</div>
<div style="">Was going to say no need for braces here, but
I missed the Swap = at the end of the line, how about
putting that on the next line so it's more clear?</div>
</div>
</div>
</div>
</blockquote>
Okay.<br>
<br>
Thank you again!<br>
<br>
<blockquote
cite="mid:CALehDX7L24kbmMbZb-mXKEMXucTEF-LmFzgwan6fTnM4P+_qeg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<div style="">
-eric</div>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>